Repository navigation
fix: resolved the intermittent HR issue related to not passing the cross team check gate - #1172
Merged
Merged
Conversation
Coverage Report •
|
||||||||||||||||||||||||||||||
Roopan-Microsoft
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the
create_RAI_agentutility to ensure that the originalteamobject passed by the caller is not mutated. Instead, a copy is created and modified for use in the RAI agent, improving code safety and preventing unintended side effects. The tests are updated and expanded to verify this behavior.Refactoring to prevent mutation of input team:
src/backend/common/utils/team_utils.py: Instead of modifying the inputteamobject directly, the function now creates a copy usingmodel_copy(update={...})to set the RAI-specific fields. This prevents accidental changes to the caller's team object.src/backend/common/utils/team_utils.py: The copiedrai_teamis now passed to the agent asteam_config, ensuring the original team remains unchanged.Test updates and new regression test:
src/tests/backend/common/utils/test_team_utils.py: Updated assertions to check that the copied team object is used for the agent, and that the original team is not mutated.src/tests/backend/common/utils/test_team_utils.py: Added a new regression test to explicitly verify that the caller's team retains its original identity and data after callingcreate_RAI_agent.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information