Fix lakeshore336/335/372 snapshot bug - #8520
Open
Nikolaos Chatzaras (SnX59) wants to merge 9 commits into
Open
Nikolaos Chatzaras (SnX59) wants to merge 9 commits into
Nikolaos Chatzaras (SnX59) wants to merge 9 commits into
Conversation
Updated the Lakeshore Model 336 driver to exclude output-type field for heater setup and disable heater setup for unpowered outputs.
Added parameters for heater output setup including output type, heater resistance, maximum current, and display settings. Enhanced functionality for heater output configuration.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8520 +/- ##
==========================================
+ Coverage 72.19% 72.21% +0.02%
==========================================
Files 307 307
Lines 32322 32353 +31
==========================================
+ Hits 23336 23365 +29
- Misses 8986 8988 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Author
Move Lakeshore heater setup to output subclasses and also extended the fix to the 335 and 372 models.
Removed spaces in setter queries for consistency.
Collaborator
|
Nikolaos Chatzaras (@SnX59) Looks good from a code perspective. Let me know if testing is needed on real hardware |
Jens Hedegaard Nielsen (jenshnielsen)
approved these changes
Oct 2, 2026
Author
I will playtest it on a Lakeshore336 to see that it works without any issues and then I'll complete the PR. Thanks for the support Jens Hedegaard Nielsen (@jenshnielsen)! |
The earlier fix LakeshoreBaseOutput no longer adds the heater setup parameters. The 4-field class LakeshoreBaseOutputWithHeaterSetup is used by 336 outputs 1 and 2. The 5-field class with an output type is used by the 335. 336 outputs 3 and 4 get no heater setup parameters. The 372 had only been moved onto the 5-field class so that its behaviour wouldn't change.
Nikolaos Chatzaras (SnX59)
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 336's HTRSET has no output_type field, and its voltage outputs 3 & 4 don't support HTRSET at all. Group._separator_parser then mis-zipped parameter names against the shorter instrument response, producing one Snapshot: Could not update parameter warning per heater-setup parameter.
Model 335 and 372 behavior is unchanged. I scoped the fix to the reported 336 issue but perhaps it might be important to update those drivers too!