Remove deepdiff test dependency - #8553
Merged
Jens Hedegaard Nielsen (jenshnielsen) merged 1 commit intoOct 2, 2026
Merged
Jens Hedegaard Nielsen (jenshnielsen) merged 1 commit into
Jens Hedegaard Nielsen (jenshnielsen) merged 1 commit into
Conversation
deepdiff appears to be unmaintained. Replace its three uses in the tests with direct comparisons: - test_converters: compare interdependencies via InterDependencies equality, which ignores paramspec order (the only difference the v0 conversion introduces) while still checking depends_on order. - test_dataset_in_memory: compare every array with numpy.testing.assert_array_equal(strict=True), which treats NaNs as equal and checks shape and dtype. Also drop deepdiff and its transitive dependencies cachebox and orderly-set from requirements.txt.
Jens Hedegaard Nielsen (jenshnielsen)
requested a review
from a team
as a code owner
October 1, 2026 19:58
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8553 +/- ##
=======================================
Coverage 72.19% 72.19%
=======================================
Files 307 307
Lines 32322 32322
=======================================
Hits 23336 23336
Misses 8986 8986 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jens Hedegaard Nielsen (jenshnielsen)
enabled auto-merge
October 2, 2026 13:47
doktorfysik
approved these changes
Oct 2, 2026
esben (esbenh4)
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deepdiff appears to be unmaintained. Replace its three uses in the tests with direct comparisons:
Also drop deepdiff and its transitive dependencies cachebox and orderly-set from requirements.txt.