Fixes and enhancements to TinyCalendar tool - #162
Open
pkonal23 wants to merge 1 commit into
Open
Conversation
- Fix critical typo: self.calenar -> self.calendar (was creating separate dict) - Fix dict unpacking bug: add_event(**event_content) instead of add_event(event_content) - Add 'date' and 'owner' to valid_keys validation - Implement find_events() with date and optional hour/minute filtering - Add list_events() for cross-date chronological listing - Add delete_event() with optional start_time disambiguation - Add FIND_EVENTS, LIST_EVENTS, DELETE_EVENT action types for LLM agents - Add attendee notification via optional world reference (socialize + mutual access) - Add calendar state to serializable_attributes for JSON persistence - Add comprehensive test suite: 38 tests covering all CRUD + edge cases - Remove 'TODO under development' tag - Update actions_definitions_prompt and actions_constraints_prompt
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete rewrite of the TinyCalendar tool — from a broken stub with critical bugs to a fully functional calendar with 4 LLM action types.
Changes
Bug Fixes
self.calenar→self.calendar(was creating a separate dict, causing silent data loss)add_event(**event_content)instead ofadd_event(event_content)(was passing dict as date parameter)"date"and"owner"to valid_keys in_process_actionNew Features
find_events()— query events by date with optional hour/minute filteringlist_events()— cross-date chronological listing with optionalmax_resultslimitdelete_event()— remove events by title with optionalstart_timedisambiguation; cleans up empty date keysworldreference is provided, attendees receive asocialize()notification and both agents are made mutually accessible"calendar"added toserializable_attributesfor full state persistence viato_json()/from_json()Prompt Improvements
actions_definitions_prompt— documented all 4 action types with field descriptions and mandatory/optional annotationsactions_constraints_prompt— replaced empty stub with 8 actionable constraints including format rules and usage guidanceCode Quality
# TODO under developmenttagtextwrapimport (replaced withutils.dedent)Tests