Python: Add core session tests and Windows emulator repair script - #7457
Python: Add core session tests and Windows emulator repair script#7457HASSanHASSgit wants to merge 4 commits into
Conversation
…e tests - Add tests for _session_file_stem encoding and edge cases - Add tests for _contains_non_finite_float nested detection - Add tests for default state encoder/decoder error and pydantic decoder Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ps1) - Add admin PowerShell script to re-install/repair Hyper-V, WSL, VirtualMachinePlatform, Containers Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
GitHub Actions
Error
GitHub Actions
Inactive
GitHub Actions
Inactive
agent-framework-automation
Bot
added
the
python
GitHub Actions
Inactive
github-actions
Bot
changed the title
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Pull request overview
Adds additional Python unit tests for core session helper behavior (filename-safe session IDs, nested non-finite float detection, and default state codec edge cases) and introduces a Windows-only PowerShell convenience script intended to “repair” common virtualization/emulator optional features by disabling and re-enabling them.
Changes:
- Added new core session edge-case tests covering
_session_file_stem,_contains_non_finite_float, and default state encoder/decoder paths. - Added a Windows PowerShell script to toggle key virtualization-related optional Windows features and optionally restart the machine.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
python/packages/core/tests/core/test_sessions_additional.py |
New unit tests to improve coverage for session filename/serialization helper edge cases. |
tools/windows/repair-emulators.ps1 |
New admin PowerShell script to disable/re-enable virtualization features commonly needed for emulators/WSL. |
| # 5. إنهاء العملية وإشعار المستخدم بإعادة التشغيل | ||
| Write-Host "`n=== اكتملت العملية بنجاح! ===" -ForegroundColor Green |
| Professional Script to Reinstall and Repair All Core Windows Emulators & Virtualization Capabilities. | ||
| .DESCRIPTION | ||
| This script runs with Administrator privileges to safely remove and clean-reinstall | ||
| Hyper-V, Virtual Machine Platform, Windows Sandbox, and WSL Components. |
| if (-not $isAdmin) { | ||
| Write-Error "خطأ: يجب تشغيل هذا السكربت كمسؤول (Run as Administrator)!" | ||
| Exit |
| Write-Host "`n=== بدء عملية إعادة تثبيت وإصلاح المحاكيات وأنظمة الافتراضية ===`n" -ForegroundColor Cyan | ||
|
|
…ators.ps1 error reporting, bilingual messages, and admin exit code - Remove unused 'math' import from tests - Repair script: exit non-zero when not admin, track failed features and report them, make messages bilingual (Arabic/English), fix docstring to reflect toggled features Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
GitHub Actions
Inactive
|
Automated: I attempted to reply-and-resolve inline review threads but the helper failed for comment IDs: 3690334805, 3690334839, 3690334855, 3690334881, 3690334899. The code fixes are committed and pushed to HASSanHASSgit:hassanhassgit-animated-journey. Please review the updated changes; if you need me to retry the helper, I will. (Automated note) |
|
Thanks — pushed fixes addressing the review threads on tools/windows/repair-emulators.ps1:
Attempted to run the repo's reply-and-resolve helper to post per-thread replies and mark threads resolved, but the helper failed here with a WSL mount error (HCS ERROR_PATH_NOT_FOUND). I prepared and attempted replies; helper could not complete in this environment. Please re-check the four review threads — the fixes are in branch HASSanHASSgit:hassanhassgit-animated-journey. If desired, I can retry the helper once more here, or you can run the bundled reply-and-resolve helper from a machine with working WSL to mark threads resolved automatically. |
|
Reply to review thread PRRT_kwDOOhTcGM6VaUjq:\n\nThanks — updated the script to track failed features, report failures, and exit non-zero when features fail to enable. Changes pushed to HASSanHASSgit:hassanhassgit-animated-journey; please re-check. |
|
Reply to review thread PRRT_kwDOOhTcGM6VaUj4:\n\nUpdated the script header to list the exact features toggled. Windows Sandbox was not included intentionally; let me know if you want it added. |
|
Reply to review thread PRRT_kwDOOhTcGM6VaUkK:\n\nNow exits with code 1 when not run as Administrator so callers can detect failure. |
|
Reply to review thread PRRT_kwDOOhTcGM6VaUkZ:\n\nMade user-facing messages bilingual (Arabic/English) so broader contributors can understand prompts and results. |
GitHub Actions
Inactive
|
Summary of fixes and request for thread resolution:
Request: Please re-check the updated files and, if satisfied, either run the repo's reply-and-resolve helper from a WSL-capable machine to mark inline threads resolved, or confirm in a comment so I can proceed. If you prefer, I can retry the helper here (low chance of success) — tell me which you prefer. Thanks! |
Motivation & Context
Add missing edge-case tests for core session utilities and provide a convenience PowerShell script to repair common Windows virtualization components. These changes improve test coverage for session serialization/filename logic and add an admin script to help Windows developers recover corrupted virtualization features.
Description & Review Guide
What are the major changes?
What is the impact of these changes?
What do you want reviewers to focus on?
Related Issue
Fixes #
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix) — a workflow keeps the label and title prefix in sync automatically.