Skip to content

feat: support GraphModel and Ontology items - #289

Merged
ohadedry merged 2 commits into
microsoft:mainfrom
ohadedry:support-ontology-graphmodel-items
Sep 23, 2026
Merged

ohadedry merged 2 commits into
microsoft:mainfrom
ohadedry:support-ontology-graphmodel-items

Conversation

@ohadedry

@ohadedry ohadedry commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

📥 Pull Request

✨ Description of new changes

Add support of 2 item types - GraphModel and Ontology.

  • basic supported commands: Create, remove, get, set, export, import, bulk-export
  • support refresh GraphModel job
  • copy and move of single items of these types are not supported
  • documentation was updated accordingly, including one limitation in bulk-export command
  • Adding e2e tests

Copilot AI lite review requested due to automatic review settings September 22, 2026 10:44
@ohadedry
ohadedry requested a review from a team as a code owner September 22, 2026 10:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The bulk-export configuration conflicts with the documented Ontology folder limitation, and requested bulk-export and GraphModel job coverage is missing.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

Adds GraphModel and Ontology support across CLI operations, exports/imports, jobs, documentation, and end-to-end recordings.

Changes:

  • Adds item types, API mappings, and GraphModel job support.
  • Extends command tests and recordings.
  • Updates documentation and changelog, including the Ontology bulk-export limitation.
File Summary
tests/​test_commands/​test_export.py Updates export expectations for the new item types.
tests/​test_commands/​recordings/​test_commands/​test_set/​class_setup.yaml Adds set-command recording setup.
tests/​test_commands/​recordings/​test_commands/​test_rm/​test_rm_item_without_force_success[GraphModel].yaml Records successful non-forced GraphModel removal.
tests/​test_commands/​recordings/​test_commands/​test_rm/​test_rm_item_without_force_cancel_operation_success[Ontology].yaml Records the Ontology removal cancellation flow.
tests/​test_commands/​recordings/​test_commands/​test_rm/​test_rm_item_without_force_cancel_operation_success[GraphModel].yaml Records the GraphModel removal cancellation flow.
tests/​test_commands/​recordings/​test_commands/​test_rm/​test_rm_item_with_hard_delete_without_force_success[GraphModel].yaml Records hard-delete GraphModel removal.
tests/​test_commands/​recordings/​test_commands/​test_rm/​test_rm_item_success[GraphModel].yaml Records successful GraphModel removal.
tests/​test_commands/​recordings/​test_commands/​test_rm/​class_setup.yaml Adds removal-command recording setup.
tests/​test_commands/​recordings/​test_commands/​test_mkdir/​class_setup.yaml Adds mkdir recording setup.
tests/​test_commands/​recordings/​test_commands/​test_ls/​class_setup.yaml Adds listing recording setup.
tests/​test_commands/​recordings/​test_commands/​test_import/​class_setup.yaml Adds import recording setup.
tests/​test_commands/​recordings/​test_commands/​test_get/​class_setup.yaml Adds get-command recording setup.
tests/​test_commands/​recordings/​test_commands/​test_export/​class_setup.yaml Adds export recording setup.
tests/​test_commands/​recordings/​test_commands/​test_exists/​test_exists_item_exists_success[GraphModel].yaml Records GraphModel existence checks.
tests/​test_commands/​recordings/​test_commands/​test_exists/​class_setup.yaml Adds exists-command recording setup.
tests/​test_commands/​recordings/​test_commands/​test_cd/​test_cd_item_all_types_success[GraphModel].yaml Records changing into a GraphModel item.
tests/​test_commands/​recordings/​test_commands/​test_cd/​class_setup.yaml Adds cd-command recording setup.
tests/​test_commands/​conftest.py Extends parameterized test fixtures.
src/​fabric_cli/​core/​fab_types.py Adds item and API/job mappings.
src/​fabric_cli/​core/​fab_config/​command_support.yaml Configures command support for the new item types.
docs/​examples/​job_examples.md Documents GraphModel job examples.
docs/​examples/​item_examples.md Updates item and export examples.
docs/​essentials/​resource_types.md Documents the new resource types.
docs/​commands/​fs/​bulk_export.md Documents bulk-export support and limitations.
.changes/​unreleased/​new-items-20260922-103546.yaml Adds release metadata.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/fabric_cli/core/fab_config/command_support.yaml
Comment thread src/fabric_cli/core/fab_types.py
Copilot AI review requested due to automatic review settings September 23, 2026 10:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

GraphModel refresh routing and coverage, along with documented follow-up fixes, remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
Resolved since last review (2)

Comment thread src/fabric_cli/core/fab_types.py
@ohadedry
ohadedry merged commit 0183fbf into microsoft:main Sep 23, 2026
10 checks passed
@ohadedry
ohadedry deleted the support-ontology-graphmodel-items branch September 23, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants