Advertise SMART permission-v1 capability - #5785
Open
Jared Erwin (feordin) wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e7826625-1c9d-4d53-8111-42011ebf21b5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5785 +/- ##
==========================================
+ Coverage 78.28% 78.86% +0.57%
==========================================
Files 1016 1016
Lines 36940 36941 +1
Branches 5619 5619
==========================================
+ Hits 28920 29133 +213
+ Misses 6644 6425 -219
- Partials 1376 1383 +7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
permission-v1to the capabilities advertised by/.well-known/smart-configurationwhile retaining the existingpermission-v2capability. Adds explicit regression coverage for both values.Related issues
N/A.
Testing
dotnet test .\src\Microsoft.Health.Fhir.R4.Core.UnitTests\Microsoft.Health.Fhir.R4.Core.UnitTests.csproj --filter "FullyQualifiedName~GetSmartConfigurationHandlerTests" --verbosity quiet(11 passed)FHIR Team Checklist
Semver Change (docs)
Patch — adds a missing advertised capability without changing API compatibility.