Fix flaky missing stats test - #5786
Closed
Jared Erwin (feordin) wants to merge 1 commit into
Closed
Conversation
Limit the negative statistics assertion to cache entries created by the current search. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 39585a39-0827-406f-bff1-bc964d379afd
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5786 +/- ##
==========================================
+ Coverage 78.28% 78.90% +0.61%
==========================================
Files 1016 1016
Lines 36940 36940
Branches 5619 5619
==========================================
+ Hits 28920 29148 +228
+ Misses 6644 6413 -231
- Partials 1376 1379 +3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevents
GivenMissingTrueSearchForPatientByGender_NotExistsStatsAreCreatedfrom failing based on test execution order. The test now checks only statistics introduced by the current search, while still detecting unintended resource-type fan-out.Related issues
N/A.
Testing
the test in question is updated
FHIR Team Checklist
Semver Change (docs)
Skip (test-only reliability fix)