Skip to content

Fix flaky missing stats test - #5786

Closed
Jared Erwin (feordin) wants to merge 1 commit into
mainfrom
users/jaerwin/fix-missing-stats-test
Closed

Fix flaky missing stats test#5786
Jared Erwin (feordin) wants to merge 1 commit into
mainfrom
users/jaerwin/fix-missing-stats-test

Conversation

@feordin

@feordin Jared Erwin (feordin) commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

Prevents GivenMissingTrueSearchForPatientByGender_NotExistsStatsAreCreated from failing based on test execution order. The test now checks only statistics introduced by the current search, while still detecting unintended resource-type fan-out.

Related issues

N/A.

Testing

the test in question is updated

FHIR Team Checklist

  • PR title is succinct and less than 65 characters
  • Add the sprint milestone
  • CI is green before merge
  • No system design assumptions changed; no ADR required
  • Reviewed squash-merge requirements

Semver Change (docs)

Skip (test-only reliability fix)

Limit the negative statistics assertion to cache entries created by the current search.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 39585a39-0827-406f-bff1-bc964d379afd
@feordin
Jared Erwin (feordin) requested a review from a team as a code owner September 2, 2026 16:24
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.90%. Comparing base (20d379f) to head (d6ea403).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5786      +/-   ##
==========================================
+ Coverage   78.28%   78.90%   +0.61%     
==========================================
  Files        1016     1016              
  Lines       36940    36940              
  Branches     5619     5619              
==========================================
+ Hits        28920    29148     +228     
+ Misses       6644     6413     -231     
- Partials     1376     1379       +3     

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@feordin Jared Erwin (feordin) added Enhancement-Test Enhancement on tests. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Schema Version unchanged No-PaaS-breaking-change labels Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement-Test Enhancement on tests. No-PaaS-breaking-change Schema Version unchanged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants