-
Notifications
You must be signed in to change notification settings - Fork 251
[BICEP] FinOps Toolkit - Custom resource naming #1105
Copy link
Copy link
Labels
OKR: 2.3 FeedbackIssues that are based on the top voted customer feedbackIssues that are based on the top voted customer feedbackSkill: DeploymentResource deployment automation via bicep or terraformResource deployment automation via bicep or terraformStatus: 🔬 Code reviewIssue is currently in code review with open PRsIssue is currently in code review with open PRsTool: FinOps hubsData pipeline solutionData pipeline solutionType: Feature 💎Idea to improve the productIdea to improve the product
Milestone
Description
Activity
Metadata
Metadata
Assignees
Labels
OKR: 2.3 FeedbackIssues that are based on the top voted customer feedbackIssues that are based on the top voted customer feedbackSkill: DeploymentResource deployment automation via bicep or terraformResource deployment automation via bicep or terraformStatus: 🔬 Code reviewIssue is currently in code review with open PRsIssue is currently in code review with open PRsTool: FinOps hubsData pipeline solutionData pipeline solutionType: Feature 💎Idea to improve the productIdea to improve the product
The bicep deployment doesn't allow the names of the resources to be set. This means that companies with naming standards can't deploy FinOps using bicep or the accept the resources won't adhere to their naming standards.
🛠️ Solution
Update the bicep code to include parameters for the names of the keyvault, data factory and storage accounts, this means that consumers can generate names using their own bicep naming modules and pass it through to the FinOps Toolkit deployment, providing a repeatable deployment.
ℹ️ Additional context
Looking at the FinOps Toolkit bicep code the main.bicep should be fairly easy to update for the data factory and storage account as there are two variables that are set.

The keyvault name appears to be set within the keyvault.bicep so that would need a parameter defining and the main.bicep updating to pass through said parameter.
I believe parameters can have default values set, so these could be set to what the bicep deployment currently uses, that way it wouldn't break existing deployments.
This was originally posted in the wrong place;
Azure/bicep-registry-modules#3740 (comment)
🙋♀️ Ask for the community
We could use your help: