Skip to content

Add compile commands - #108

Merged
Chenglong Wang (Chenglong-MS) merged 2 commits into
microsoft:devfrom
chen1plus:ac-branch-2
Sep 1, 2026
Merged

Add compile commands#108
Chenglong Wang (Chenglong-MS) merged 2 commits into
microsoft:devfrom
chen1plus:ac-branch-2

Conversation

@chen1plus

Copy link
Copy Markdown

Closes #107

I used AI, but I've reviewed the output

@chen1plus

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@IAMkecheng IAMkecheng left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR — I tried this locally and it works well (compile tests + smoke: SVG/PNG, relative data.url, echarts, and the chartjs+svg rejection). The change is additive and doesn’t appear to break the existing flint-chart-mcp path.

Approve with a couple of nits:

  1. Binary name. I’d prefer renaming the top-level binary from flint to flint-chart. flint alone is a bit too generic and easy to collide with other tools; flint-chart matches the product/repo naming and pairs cleanly with flint-chart-mcp (flint-chart for local CLI work, flint-chart-mcp for the server). Keeping the compile subcommand is fine, e.g. flint-chart compile chart.json --format svg.
  2. Docs. Please follow up (in this PR or a quick follow-up) with a short section in packages/flint-mcp/README.md documenting flint compile (basic usage, --format / --backend / -o, and how relative data.url resolves).

Overall, it's a nice fix for #107.

@chen1plus

Copy link
Copy Markdown
Author

Updated per your feedback, PTAL when you get a chance

@Chenglong-MS

Copy link
Copy Markdown
Contributor

Thank you both! Merging to the dev branch to stage for the next release.

Btw, if you are feeling adventurous, you are welcome to explore some of the interactive feature we are releasing soon in the dev branch. Available in the playground once you launch the local site: http://localhost:5274/#/playground/click-focus

@Chenglong-MS
Chenglong Wang (Chenglong-MS) merged commit c9074c8 into microsoft:dev Sep 1, 2026
1 check passed
@chen1plus
Aaron Chen (chen1plus) deleted the ac-branch-2 branch September 2, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a CLI command to compile chart JSON to SVG

3 participants