[Austin Aviv (austinaviv)]

Summary

Fixes IndexOutOfRangeException in StringExtensions.ToSnakeCase under multiple edge cases:

• Guard against accessing
  ameSpan[i + 1] when the input string ends with a hyphen.
• Return empty string early if stripping generic arguments with < results in an empty span before indexing
  ameSpan[0].
• Handle leading hyphen followed by uppercase without buffer overrun.
• Return sliced span
  ew string(span[..counter]) to avoid returning uninitialized or null characters if fewer characters are written than allocated.
• Add unit test coverage for trailing hyphens, generic arguments, leading hyphens with uppercase and lowercase, and consecutive hyphens.

Validation

dotnet test tests/Kiota.Builder.Tests/Kiota.Builder.Tests.csproj --no-restore --nologo --filter 'FullyQualifiedName!~KiotaSearcherTests' --verbosity quiet (2,899 passed, 2 skipped)
dotnet test tests/Kiota.Tests/Kiota.Tests.csproj (18 passed)

Fixes #8388

[github-actions]

Thanks for opening this pull request! Please add a changelog entry under ## [Unreleased] in CHANGELOG.md, before the first released version section, so users can see what changed. Add bug fixes under ### Changed and new features under ### Added.

[Copilot]

🟡 Changes recommended

Custom '-' separators are incorrectly omitted before uppercase characters.

1 open finding

• Custom hyphen separator drops hyphens before uppercase letters · New

What changed in this PR

Fixes edge-case failures and malformed output in ToSnakeCase.

Changes:

• Handles empty generic prefixes and boundary hyphens safely.
• Returns only initialized output characters.
• Adds regression tests for reported edge cases.

File	Description
src/​Kiota.Builder/​Extensions/​StringExtensions.cs	Hardens snake-case conversion logic.
tests/​Kiota.Builder.Tests/​Extensions/​StringExtensionsTests.cs	Adds edge-case coverage.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟢 Approval recommended

The implementation addresses the reported bounds errors and includes focused regression tests.

0 open findings

1 resolved since last review

• Custom hyphen separator drops hyphens before uppercase letters

🧠 Review effort: Balanced

[Copilot]

🔵 Needs a closer look

The span-slicing fix lacks a regression test that exercises an overallocated buffer.

0 open findings

Previously missed (1)

In code that hasn't changed since last review

Add custom-separator test for span allocation fix

tests/​Kiota.Builder.Tests/​Extensions/​StringExtensionsTests.cs:87

The new cases do not exercise the span[..counter] fix: with the default separator, each of these inputs fills the allocated span exactly, so reverting that fix would still pass. Add a custom-separator case such as "a.B".ToSnakeCase('.'), where separator counting allocates four chars but only three are written, to prevent trailing-null regressions.

🧠 Review effort: Balanced

[Austin Aviv (austinaviv)]

Hi maintainers, could you please approve the workflow run for this PR? Thank you!

[Copilot]

🟢 Approval recommended

The implementation addresses each reported failure mode with focused regression coverage.

0 open findings

🧠 Review effort: Balanced

[Copilot]

🟢 Approval recommended

The targeted fixes include regression coverage, and no unresolved blocking issues were identified.

0 open findings

🧠 Review effort: Balanced

[github-actions]

Conflicts have been resolved. A maintainer will take a look shortly.

[Copilot]

🟢 Approval recommended

The localized fixes address the reported failures with regression coverage and no identified blocking issues.

No open issues 🎉

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

The targeted fixes address the reported failures with regression coverage and no unresolved findings.

No open issues 🎉

_{Review effort: Balanced}