Repository navigation
feat(ruby): register the text, form and multipart serializers - #8443
Open
Andrea Peruffo (andreaTP) wants to merge 3 commits into
Open
Andrea Peruffo (andreaTP) wants to merge 3 commits into
Andrea Peruffo (andreaTP) wants to merge 3 commits into
Conversation
Contributor
|
Thanks for opening this pull request! Please link it to an issue by adding the fixes syntax to the pull request description, for example: |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Approval requires confirmation of the Ruby 0.25.0 release, corresponding lockfile update, and successful runtime integration validation.
No open issues 🎉
What changed in this PR
Enables non-JSON serialization in generated Ruby clients, building on #8441’s runtime dependency update.
Changes:
- Registers text, form and multipart writers, plus text and form parse nodes.
- Updates Ruby dependencies to 0.25.0 and documents serialization support.
- Adds registration tests and request-body integration coverage.
| File | Description |
|---|---|
| tests/Kiota.Builder.Tests/Refiners/RubyLanguageRefinerTests.cs | Verifies factory registrations and imports. |
| tests/Kiota.Builder.IntegrationTests/RequestBodies.yaml | Defines form, multipart and text endpoints. |
| src/kiota/appsettings.json | Lists required Ruby 0.25.0 gems. |
| src/Kiota.Builder/Refiners/RubyRefiner.cs | Registers additional serialization factories. |
| serialization/README.md | Updates Ruby serialization links. |
| README.md | Lists Ruby serialization support. |
| it/ruby/spec/request-bodies/integration_test_request_bodies.rb | Checks body bytes and parse-node registration. |
| it/ruby/Gemfile | Adds serializers and updates runtime versions. |
| it/config.json | Maps the request-body integration fixture. |
| CHANGELOG.md | Records Ruby support and dependency changes. |
| .github/workflows/integration-tests.yml | Adds the fixture to integration testing. |
Review effort: Balanced
Andrea Peruffo (andreaTP)
force-pushed
the
feat/ruby-serialization-modules
branch
from
October 20, 2026 09:32
0499ae5 to
4f7dd81
Compare
Andrea Peruffo (andreaTP)
marked this pull request as ready for review
October 20, 2026 09:32
Andrea Peruffo (andreaTP)
force-pushed
the
feat/ruby-serialization-modules
branch
from
October 20, 2026 16:53
4f7dd81 to
15fb10f
Compare
Vincent Biret (baywet)
previously approved these changes
Oct 20, 2026
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
Vincent Biret (baywet)
enabled auto-merge
October 20, 2026 18:06
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 21, 2026
- the client registers the text, form and multipart writers and the text and form parse nodes - appsettings.json and the IT Gemfile list the three gems - RequestBodies.yaml with a Ruby spec checking the bytes of each body
Andrea Peruffo (andreaTP)
force-pushed
the
feat/ruby-serialization-modules
branch
from
October 21, 2026 13:21
15fb10f to
4310b57
Compare
Contributor
|
Conflicts have been resolved. A maintainer will take a look shortly. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Ruby clients registered only JSON, so
text/plain, form and multipart bodies failed with "could not serialize payload". The client now registers the text, form and multipart writers and the text and form parse nodes, as Python does, andappsettings.jsonlists the new gems.New
RequestBodies.yamlin the IT, with a Ruby spec checking the exact bytes of a form, a multipart and a text body: it fails on main and passes here. MockServer skips multipart operations and only matches JSON text bodies, so the spec checks the request in memory, like the query-params spec. The description builds in all languages.Builds on #8441. The Ruby IT passes on all its descriptions against the published 0.25.0 gems.