Switched from the stdlib minidom parser to defusedxml.#1259
Merged
Conversation
azhao25
pushed a commit
to azhao25/markitdown
that referenced
this pull request
Oct 16, 2025
claymorenjoyer
pushed a commit
to claymorenjoyer/markitdowngui
that referenced
this pull request
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to improve XML handling in the
markitdownpackage by replacing the use of the standardxml.dom.minidommodule with the more securedefusedxml.minidom. The changes also update type annotations to useDocumentandElementdirectly fromxml.dom.minidom. These updates enhance security and maintain consistency in type annotations.Security Improvements:
defusedxmlas a dependency inpyproject.tomlto replace the standardxml.dom.minidomfor safer XML parsing. (packages/markitdown/pyproject.toml, packages/markitdown/pyproject.tomlR32)xml.dom.minidomwithdefusedxml.minidomin_epub_converter.pyand_rss_converter.pyfor improved security. (packages/markitdown/src/markitdown/converters/_epub_converter.py, [1];packages/markitdown/src/markitdown/converters/_rss_converter.py, [2]Code Consistency:
_epub_converter.pyto useDocumentfromxml.dom.minidominstead ofminidom.Document. (packages/markitdown/src/markitdown/converters/_epub_converter.py, packages/markitdown/src/markitdown/converters/_epub_converter.pyL131-R140)_rss_converter.pyto useDocumentandElementdirectly, ensuring consistent usage across methods. (packages/markitdown/src/markitdown/converters/_rss_converter.py, [1] [2] [3]