Repository navigation
fix: serialize AI Foundry resource updates - #96
Merged
Merged
Conversation
🔧 - Generated by Copilot
fix: serialize AI Foundry resource updates
Copilot started reviewing on behalf of
Yamini Dhiman (Yamini1-Microsoft)
October 6, 2026 10:05
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependencies consistently serialize conflicting Foundry updates while preserving identity and role-assignment behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Serializes Azure AI Foundry resource updates to prevent deployment conflicts and corrects existing-resource identity handling.
Changes:
- Deploys AI projects only after model deployments complete.
- Sequences existing-resource role-assignment modules.
- Uses existing identities without re-enabling system-assigned identity.
| File | Description |
|---|---|
infra/deploy_foundry_role_assignment.bicep |
Orders project creation after model deployments. |
infra/deploy_ai_foundry.bicep |
Adds deployment ordering and corrects existing-project identity parameters. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Roopan-Microsoft
approved these changes
Oct 6, 2026
Prajwal-Microsoft
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the deployment Bicep templates to improve resource deployment ordering and adjust identity configuration for role assignments related to Azure AI and Search services. The changes ensure that dependencies are explicitly declared and correct identity settings are used during role assignment.
Deployment dependency improvements:
dependsOnclauses to both theaiProjectandaiProjectWithIdentityresources to ensure they are deployed only afteraiServicesDeploymentscompletes, preventing potential race conditions during resource provisioning. [1] [2]Role assignment and identity handling:
existingOpenAiProjectmodule to depend onassignFoundryRoleToMIExisting, ensuring proper sequencing of role assignments.enableSystemAssignedIdentityparameter fromtruetofalsein theexistingOpenAiProjectmodule parameters, aligning the configuration with the intended identity usage for role assignments.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information