Repository navigation
FIX: Revert "RELEASE: mssql-python-odbc 18.6.2.2" - #815
Closed
gargsaumya wants to merge 1 commit into
Closed
gargsaumya wants to merge 1 commit into
gargsaumya wants to merge 1 commit into
Conversation
This reverts commit 1c14bb9.
PR Performance ReportPerformance could not be assessed. Pull request closed before assessment completed. No result is available. |
gargsaumya
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Fix the macOS version parser to accept the packaging-revision component.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Reverts the ODBC companion package release from 18.6.2.2 to 18.6.2.1.
Changes:
- Restores package metadata, documentation, and test expectations.
- Updates macOS dylib version parsing.
- The parsing regex does not accept
18.6.2.1, causing the macOS build to exit before configuration.
| File | Summary |
|---|---|
tests/test_026_odbc_provider.py |
Restores the expected ODBC version. |
README.md |
Restores 18.6.2.1 documentation. |
mssql_python/pybind/configure_dylibs.sh |
Parses the ODBC driver version; currently fails for 18.6.2.1. |
mssql_python_odbc/__init__.py |
Restores package version metadata. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| fi | ||
|
|
||
| DRIVER_MAJOR=$(sed -nE "s/^__version__[[:space:]]*=[[:space:]]*['\"]([0-9]+)\.[0-9]+\.[0-9]+(\.[0-9]+)?['\"].*/\1/p" "$ODBC_VERSION_FILE" | head -1) | ||
| DRIVER_MAJOR=$(sed -nE "s/^__version__[[:space:]]*=[[:space:]]*['\"]([0-9]+)\.[0-9]+\.[0-9]+['\"].*/\1/p" "$ODBC_VERSION_FILE" | head -1) |
📊 Code Coverage Report
Diff CoverageDiff: main...HEAD, staged and unstaged changesNo lines with coverage information in this diff. 📋 Files Needing Attention📉 Files with overall lowest coverage (click to expand)mssql_python.pybind.performance_counter.hpp: 0.7%
mssql_python.pybind.logger_bridge.cpp: 57.9%
mssql_python.pybind.ddbc_bindings.h: 64.1%
mssql_python.pybind.logger_bridge.hpp: 70.8%
mssql_python.pybind.ddbc_bindings.cpp: 78.7%
mssql_python.pybind.connection.connection_pool.cpp: 82.3%
mssql_python.pybind.connection.connection.cpp: 83.1%
mssql_python.logging.py: 86.2%
mssql_python.pooling.py: 90.1%
mssql_python.pybind.fetch_temporal.hpp: 92.1%🔗 Quick Links
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #807