Skip to content

CHORE: Deduplicate tests while preserving coverage and edge cases #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jahnvi Thakkar (jahnvi480) merged 5 commits into from
Oct 6, 2026
+3,712 −6,120
Merged

CHORE: Deduplicate tests while preserving coverage and edge cases #833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69e9c49
REFACTOR: Deduplicate pytest coverage without dropping Binary edge cases
jahnvi480 Oct 5, 2026
adbdfaf
Merge branch 'main' into jahnvi/scaling-spoon
jahnvi480 Oct 5, 2026
5788448
FIX: Detect duplicate tests inside scope-level control flow
jahnvi480 Oct 5, 2026
c17b980
FIX: Guard duplicate test classes and restore Korean VARCHAR coverage
jahnvi480 Oct 5, 2026
ef9bc0f
Fix review gaps in duplicate guard and RHEL test prerequisites
jahnvi480 Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/prompts/setup-dev-env.prompt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,13 @@ sudo apt-get install -y cmake build-essential python3-dev

**If missing (RHEL/CentOS/Fedora):**
```bash
sudo dnf install -y cmake gcc-c++ python3-devel
sudo dnf install -y cmake gcc-c++ python3-devel glibc-gconv-extra
```

`glibc-gconv-extra` supplies ODBC's iconv conversions for legacy code pages such
as Korean CP949. Minimal UBI/RHEL images omit these modules; install them before
running the encoding tests on either x64 or ARM64.

**If missing (SUSE):**
```bash
sudo zypper install -y cmake gcc-c++ python3-devel
Expand Down
6 changes: 4 additions & 2 deletions eng/pipelines/pr-validation-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1338,7 +1338,8 @@ jobs:

# Install Python 3.12 (available in RHEL 9.4+) and development tools
# Note: curl and wget omitted to avoid conflicts with curl-minimal
dnf install -y python3.12 python3.12-pip python3.12-devel python3.12-libs gnupg2 glibc-devel kernel-headers
# ODBC needs the extra iconv modules for legacy code pages such as Korean CP949.
dnf install -y python3.12 python3.12-pip python3.12-devel python3.12-libs gnupg2 glibc-devel glibc-gconv-extra kernel-headers
Comment thread
jahnvi480 marked this conversation as resolved.
dnf install -y gcc gcc-c++ make binutils cmake
# If that doesn't work, try installing from different repositories
if ! which gcc; then
Expand Down Expand Up @@ -1551,7 +1552,8 @@ jobs:

# Install Python 3.12 (available in RHEL 9.4+) and development tools
# Note: curl and wget omitted to avoid conflicts with curl-minimal
dnf install -y python3.12 python3.12-pip python3.12-devel python3.12-libs gnupg2 glibc-devel kernel-headers
# ODBC needs the extra iconv modules for legacy code pages such as Korean CP949.
dnf install -y python3.12 python3.12-pip python3.12-devel python3.12-libs gnupg2 glibc-devel glibc-gconv-extra kernel-headers
dnf install -y gcc gcc-c++ make binutils cmake
# If that doesn't work, try installing from different repositories
if ! which gcc; then
Expand Down
Loading
Loading