[Rebase & FF] Adding MM communication buffer validation - #1846
Merged
Conversation
kuqin12
marked this pull request as draft
July 10, 2026 23:47
Contributor
⏩ QEMU Validation SkippedThe PR was merged before validation completed. This comment was automatically generated by the Mu QEMU PR Validation workflow. |
kuqin12
force-pushed
the
mm_comm
branch
5 times, most recently
from
August 4, 2026 21:48
6d3b895 to
48dff23
Compare
kuqin12
marked this pull request as ready for review
August 4, 2026 21:56
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/202511 #1846 +/- ##
================================================
Coverage ? 0.50%
================================================
Files ? 30
Lines ? 5579
Branches ? 31
================================================
Hits ? 28
Misses ? 5551
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The platform validation is failed due to override hash failure. |
Aaron (apop5)
approved these changes
Aug 4, 2026
kuqin12
force-pushed
the
mm_comm
branch
3 times, most recently
from
August 13, 2026 22:50
f4e8ea1 to
9a90186
Compare
Michael Kubacki (makubacki)
approved these changes
Aug 21, 2026
kuqin12
enabled auto-merge (rebase)
August 21, 2026 20:04
…ions This change adds the SafeIntLib to communication input routine to validate the incoming MM communication message length before using. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
…ions This change adds the SafeIntLib to communication input routine to validate the incoming MM communication buffer length before using. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
This change adds the SafeIntLib to communication input routine to validate the incoming MM communication buffer length before using. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
…ic operations This change adds the SafeIntLib to communication input routine to validate the incoming MM communication buffer length before using. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
This change adds the SafeIntLib to communication input routine to validate the incoming MM communication buffer length before using. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
This change validates the returned MM communication content against the caller supplied buffer size before copying. Signed-off-by: Kun Qin <kun.qin@microsoft.com>
5 tasks
kuqin12
added a commit
to microsoft/mu_feature_mm_supv
that referenced
this pull request
Aug 22, 2026
## Description BASECORE has updated implementation of `StandaloneMmCore` to harden the incoming buffer validation microsoft/mu_basecore#1846. This was done in our core in #666. So only the override tags are updated. For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested This was tested locally and booted to OS desktop. ## Integration Instructions Use commits from basecore later than [dc5a299b61611f76002dac5c5e90ad4bda95ee11](microsoft/mu_basecore@dc5a299).
kuqin12
added a commit
to kuqin12/mu_feature_mm_supv
that referenced
this pull request
Aug 27, 2026
## Description BASECORE has updated implementation of `StandaloneMmCore` to harden the incoming buffer validation microsoft/mu_basecore#1846. This was done in our core in microsoft#666. So only the override tags are updated. For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested This was tested locally and booted to OS desktop. ## Integration Instructions Use commits from basecore later than [dc5a299b61611f76002dac5c5e90ad4bda95ee11](microsoft/mu_basecore@dc5a299).
kuqin12
added a commit
to microsoft/mu_feature_mm_supv
that referenced
this pull request
Aug 27, 2026
## Description BASECORE has updated implementation of `StandaloneMmCore` to harden the incoming buffer validation microsoft/mu_basecore#1846. This was done in our core in #666. So only the override tags are updated. For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested This was tested locally and booted to OS desktop. ## Integration Instructions Use commits from basecore later than [dc5a299b61611f76002dac5c5e90ad4bda95ee11](microsoft/mu_basecore@dc5a299).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a few validation before using the derived buffer size from message length.
However, note that the buffer size is not used directly due to a check after that. Thus the MM communication agent or the core in MM will not consume the value directly. But this would cause the MM handler to potentially receive a huge message in length.
How This Was Tested
This is tested on QEMU ARM Virt platform and booted to Windows desktop.
Integration Instructions
N/A