Repository navigation
Document generic CUDA operators and complete build compatibility - #33465
Closed
Akshay Sonawane (apsonawane) wants to merge 4 commits into
Closed
Akshay Sonawane (apsonawane) wants to merge 4 commits into
Akshay Sonawane (apsonawane) wants to merge 4 commits into
Conversation
Part of the grouped generic CUDA operator stack. Preserve the qualified source snapshot.
This was referenced Oct 19, 2026
Contributor
Author
|
Closing this draft to replace the feature-based stack with focused branches rebuilt from current main. Existing branches are preserved; replacement PRs will be linked here. |
This was referenced Oct 19, 2026
Contributor
Author
Akshay Sonawane (apsonawane)
added a commit
that referenced
this pull request
Oct 24, 2026
## Summary - Add opt-in explicit FP32 arithmetic and packed input slicing for BranchwiseRMSNorm. - Add versioned RotaryEmbedding exact arithmetic while retaining existing default dispatch. - Keep RMS-chain regression coverage with this PR, independent of tensor fusions. ## Review follow-up - Honor deterministic CUDA sessions by using the existing fixed-order column reduction instead of the single-row floating-point atomic reduction. Default dispatch remains unchanged. The schema documents that deterministic summation may round differently from the default path or deterministic ReduceMean. - Add CUDA exact-mode branch-scale parity coverage for distinct `(C, H)` and flattened `(C * H)` scales over multiple outer rows, covering FP32, FP16, and BF16 input and scale storage. - Add a width-8192 single-row deterministic-session regression with a numerical reference, repeated bitwise comparison, and widened-output checks. - Prevent GroupQueryAttentionFusion from removing either RotaryEmbedding node when `use_fp32_arithmetic` is requested. Add a version-2 graph-transformer regression for query-only, key-only, both-exact, and ordinary fusion. - Regenerate the affected contrib and kernel documentation using the official renderers with source-derived metadata, including version-2 availability/history, optional widened outputs, type constraints, and CPU/CUDA/DML registrations. Full native `--gen_doc validate` remains a CI check. ## Clean main-based replacement Supersedes #33459. Reconstructed directly on `main` (`28225b8583474cf6a6e7f97222227ae668f80e8b`), without the old divergent feature-branch history. This PR targets `main` directly and has no dependency on another operator PR. Family documentation is bundled here; the separate old documentation PR #33465 is retired. ## Validation - Used the `qwen-flash` Conda environment. - Ran `lintrunner -a` before committing, followed by a passing check-only run on the full PR delta and `git diff --check`. - Per request, the review follow-up does **not** rebuild ORT/GenAI or execute the new native/GPU tests. Their execution and full generated-documentation validation are left to CI. - The original branch was previously checked with schema syntax checks and affected CUDA/host/test translation-unit compilation (SM90); this historical compile evidence does not validate the new review follow-up. - The previous head's React Native Android failure was an npm `ETIMEDOUT` downloading `supports-color`, not a source compilation failure. CUDA builds succeeded, but CUDA test jobs were canceled. The new push starts fresh CI; no claim that all pipelines are green. - Full main-based model/GPU requalification remains outstanding; keeping this PR in draft. - No benchmark/profiling/evaluation scripts or local task metadata are included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main integration update
Merged repository
mainat9a662b9395c7c5dc619ae4d050f2c9362d88eae3. Published head:e15aebba7f976b58f4826a06461ad0f6d103c5c8. Existing PR bases remain unchanged.qwen-flashconda environment; ranlintrunner -abefore each new commit, followed by clean lint checks. Final branch-vs-main lint passes.This update supersedes earlier notes saying main has not been integrated, but does not remove the draft/build/runtime qualification requirements.
Summary
Update contrib operator/kernel documentation for the stack and include the remaining compatibility/formatting adjustments.
Stack and main target
Depends on #33464.
This is layer 7/7 of the microsoft/onnxruntime stack. The current review base is
asonawane/ported-ops-mtp-fold-stateso this PR shows only its incremental group. The final destination is upstreammain: land/reconcile prerequisites first, then rebase and retarget this layer tomain. Keep this PR in draft until that base-specific validation succeeds. Do not merge the entire stack through an unvalidated intermediate base.Cross-repository dependency: GenAI package/runtime integration requires the companion ORT contrib operators.
Validation and blockers
GatedDeltaNetTest.RecurrentOutputsIncludeFirstRowStatefails in the existing combined workspace.RejectsWrongOutputCount,QsaMalformedStateLengthsAreClamped,CsaMalformedStateLengthsAreClamped.Scope
Stack navigation
Companion repository stack: