Skip to content

Fix aten::mean dtype handling #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Promise Emmanuel Oluwadare (promiseeuler) wants to merge 1 commit into from
Closed

Fix aten::mean dtype handling #3010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions onnxscript/function_libs/torch_lib/ops/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6350,10 +6350,13 @@ def aten_maximum(self: TTensor, other: TTensor) -> TTensor:
return op.Max(self, other)


@torch_op("aten::mean")
def aten_mean(self: TReal) -> TReal:
@torch_op("aten::mean", trace_only=True)
def aten_mean(self: TReal, dtype: int = -1) -> TReal:
"""mean(Tensor self, *, ScalarType? dtype=None) -> Tensor"""

if dtype != -1:
self = op.Cast(self, to=dtype)

result = op.ReduceMean(self)
return op.Squeeze(result)

Expand Down
13 changes: 13 additions & 0 deletions tests/function_libs/torch_lib/e2e_ops_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,6 +1281,19 @@ def forward(self, x):
)
_testing.assert_onnx_program(onnx_program)

def test_mean_dtype_casts_before_reduction(self):
class Model(torch.nn.Module):
def forward(self, x):
return torch.mean(x, dtype=torch.float64)

model = Model()
x = torch.tensor([1e8, 1.0, -1e8], dtype=torch.float32)
onnx_program = torch.onnx.export(model, (x,), dynamo=True, optimize=False)

_testing.assert_onnx_program(onnx_program)
actual = onnx_program.call_reference({onnx_program.model.graph.inputs[0].name: x})[0]
torch.testing.assert_close(actual, model(x))

def test_aten_histc_float(self):
class Model(torch.nn.Module):
def forward(self, x):
Expand Down