Skip to content

fix(apple): ignore build warnings in third-party code#2853

Merged
tido64 merged 1 commit into
trunkfrom
tido/ignore-safe-area-warnings
Jul 21, 2026
Merged

fix(apple): ignore build warnings in third-party code#2853
tido64 merged 1 commit into
trunkfrom
tido/ignore-safe-area-warnings

Conversation

@tido64

@tido64 tido64 commented Jul 17, 2026

Copy link
Copy Markdown
Member

Description

See build failure: https://github.com/microsoft/react-native-test-app/actions/runs/29556174351/job/87808590476

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

cd packages/app
node --run set-react-version -- nightly
yarn
cd example
pod install --project-directory=ios
yarn ios

@github-actions github-actions Bot added platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS labels Jul 17, 2026
@tido64
tido64 force-pushed the tido/ignore-safe-area-warnings branch 2 times, most recently from 3ea0edf to bcc02a3 Compare July 21, 2026 08:09
@tido64 tido64 changed the title chore(apple): ignore warnings emitted by react-native-safe-area-context fix(apple): ignore build warnings in third-party code Jul 21, 2026
@tido64
tido64 enabled auto-merge (squash) July 21, 2026 09:03
@tido64
tido64 force-pushed the tido/ignore-safe-area-warnings branch 2 times, most recently from c7c5dfe to 592c309 Compare July 21, 2026 13:17
@tido64
tido64 force-pushed the tido/ignore-safe-area-warnings branch from 592c309 to bf1607f Compare July 21, 2026 13:38
@tido64 tido64 mentioned this pull request Jul 21, 2026
Open
14 tasks
Saadnajmi
Saadnajmi approved these changes Jul 21, 2026
View reviewed changes
Comment thread packages/app/visionos/ReactTestApp.xcodeproj/project.pbxproj
SUPPORTS_XR_DESIGNED_FOR_IPHONE_IPAD = NO;
SWIFT_OBJC_BRIDGING_HEADER = "Shared/ReactTestApp-Bridging-Header.h";
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_TREAT_WARNINGS_AS_ERRORS = NO;

@Saadnajmi Saadnajmi Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much can you move out to xcconfigs?

@tido64
tido64 merged commit c01b23a into trunk Jul 21, 2026
24 checks passed
@tido64
tido64 deleted the tido/ignore-safe-area-warnings branch July 21, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Saadnajmi Saadnajmi Saadnajmi approved these changes
@JasonVMo JasonVMo Awaiting requested review from JasonVMo JasonVMo is a code owner

Assignees

No one assigned

Labels

platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tido64 @Saadnajmi