Address tech-debt batch: analyzer/report-engine dedup, MSBuild authoring, file diet

[Evangelink]

Addresses a batch of automated tech-debt / quality issues. Each change is validated with a clean full build (build.cmd -c Debug: 0 warnings, 0 errors) and the affected unit-test suites pass.

Implemented

#9483 — Duplicate TestInitialize/TestCleanup analyzers

Extracted FixtureMethodAnalyzerHelper.RegisterInstanceFixtureAnalyzer and routed both analyzers through it. The ConfigureGeneratedCodeAnalysis/EnableConcurrentExecution calls stay in each Initialize (required by RS1025/RS1026). Public Rule fields are unchanged.

#9482 — Duplicate report-engine constructor arguments

Added ReportEngineContext (in SharedExtensionHelpers) plus a ReportGeneratorBase.CreateEngineContext(...) factory and a context-accepting ReportEngineBase constructor. The three generators (Html/JUnit/Ctrf) now build their engine from a single context instead of repeating the 10-argument list. The existing 10-parameter engine constructors are kept so the engine unit tests are untouched.

#9467 — Analyzer Category.Performance deficit (partial — safe subset)

• Reclassified MSTEST0067 (AvoidThreadSleepAndTaskWaitInTests) to Category.Performance — non-breaking because the rule is disabled by default.
• Documented the Category taxonomy decision criteria in Category.cs.
• Added AnalyzerCategoryGovernanceTests pinning MSTEST0001 and MSTEST0067 to Performance.
• Intentionally deferred the behavior-changing tasks from the issue: enabling MSTEST0067 by default, and reclassifying MSTEST0045 (Category.Design → Performance). Both affect default-enabled behavior for existing consumers and the issue itself flags MSTEST0045 as needing a changelog/next-release. Happy to do them in a follow-up if maintainers want.

#9414 — MSBuild file quality (remaining warnings)

• A-2: Declared Returns="@(MSTestV2Files)" on GetMSTestV2CultureHierarchy in both the common and uwp MSTest.TestAdapter.targets.
• A-5: Moved _ValidateBundledSdkFeatureVersions from Directory.Packages.props into Directory.Build.targets (targets belong in .targets).
• The E-1 suggestion was already addressed by Forward buildTransitive props through build/ for MTP extensions #9431.

#9464 — File diet for FfmpegVideoRecorder.cs (723 → 354 lines)

Extracted VideoSegment into its own file and split the recorder into partial files: FfmpegVideoRecorder.ProcessManagement.cs and FfmpegVideoRecorder.WindowCapture.cs. No behavioral or API changes.

Already fixed / in progress (linked, not re-done here)

• [duplicate-code] Duplicate Code: IsTypeReachableFromGeneratedCode in TestClassModelBuilder duplicates shared SymbolAccessibilityHelper #9471 — fixed by Remove duplicate IsTypeReachableFromGeneratedCode in TestClassModelBuilder #9473 (IsTypeReachableFromGeneratedCode already removed).
• [perf-improver] perf: add Linux parallel job to nightly perf-timing workflow #9399 — fixed by [perf-improver] perf: add Linux job to nightly perf-timing workflow #9450 (Linux job already present in perf-timing-nightly.yml).
• [efficiency-improver] Add server-mode (JSON-RPC) performance scenario to nightly perf pipeline #9480 — covered by the open [perf-improver] perf: add dotnet test server-mode scenario to performance runner #9486 (server-mode scenario).

Deferred

• [duplicate-code] Duplicate Code: Banner building logic duplicated between BannerMessageHelper and OutputDeviceBannerHelper #9472 — banner-building duplication between BannerMessageHelper and OutputDeviceBannerHelper. Unifying them is non-trivial: the two banners intentionally differ (culture-sensitive vs invariant date, commit-hash presence, injected vs computed arch) and live in different assemblies with a layering constraint, so a merge risks changing user-visible banner output and the --help/--info acceptance snapshots. Left for a deliberate follow-up.

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

[Copilot]

Pull request overview

This PR addresses a batch of tech-debt/quality items across MSTest analyzers, report-generation extensions, MSBuild authoring, and a large VideoRecorder source file, with the intent of reducing duplication and improving maintainability without changing behavior.

Changes:

• Deduplicated analyzer initialization code for instance fixture analyzers ([TestInitialize] / [TestCleanup]) via a shared helper.
• Introduced ReportEngineContext + a generator factory to remove repeated 10-argument report-engine construction across HTML/JUnit/CTRF (while keeping existing constructors).
• Improved analyzer category taxonomy: documented category criteria, reclassified MSTEST0067 as Performance, added governance tests; plus MSBuild authoring cleanups and VideoRecorder file split.

Show a summary per file

File	Description
test/UnitTests/MSTest.Analyzers.UnitTests/AnalyzerCategoryGovernanceTests.cs	Adds lightweight tests pinning analyzer Category values for performance-related rules
src/Analyzers/MSTest.Analyzers/AvoidThreadSleepAndTaskWaitInTestsAnalyzer.cs	Reclassifies MSTEST0067 from Usage to Performance
src/Analyzers/MSTest.Analyzers/Helpers/Category.cs	Documents decision criteria for Design/Performance/Usage taxonomy
src/Analyzers/MSTest.Analyzers/Helpers/FixtureMethodAnalyzerHelper.cs	Adds RegisterInstanceFixtureAnalyzer to centralize instance-fixture analyzer registration
src/Analyzers/MSTest.Analyzers/TestInitializeShouldBeValidAnalyzer.cs	Routes [TestInitialize] analyzer registration through shared helper
src/Analyzers/MSTest.Analyzers/TestCleanupShouldBeValidAnalyzer.cs	Routes [TestCleanup] analyzer registration through shared helper
src/Platform/SharedExtensionHelpers/ReportEngineContext.cs	Adds a context record bundling shared services + per-session arguments for report engines
src/Platform/SharedExtensionHelpers/ReportGeneratorBase.cs	Adds CreateEngineContext(...) factory to avoid repeated dependency lists in generators
src/Platform/SharedExtensionHelpers/ReportEngineBase.cs	Adds a context-based base constructor to thread dependencies through one parameter
src/Platform/Microsoft.Testing.Extensions.HtmlReport/Microsoft.Testing.Extensions.HtmlReport.csproj	Links ReportEngineContext.cs into HtmlReport extension build
src/Platform/Microsoft.Testing.Extensions.HtmlReport/HtmlReportGenerator.cs	Uses CreateEngineContext(...) to construct HtmlReportEngine
src/Platform/Microsoft.Testing.Extensions.HtmlReport/HtmlReportEngine.cs	Adds a context-taking constructor delegating to ReportEngineBase
src/Platform/Microsoft.Testing.Extensions.JUnitReport/Microsoft.Testing.Extensions.JUnitReport.csproj	Links ReportEngineContext.cs into JUnitReport extension build
src/Platform/Microsoft.Testing.Extensions.JUnitReport/JUnitReportGenerator.cs	Uses CreateEngineContext(...) to construct JUnitReportEngine
src/Platform/Microsoft.Testing.Extensions.JUnitReport/JUnitReportEngine.cs	Adds a context-taking constructor delegating to ReportEngineBase
src/Platform/Microsoft.Testing.Extensions.CtrfReport/Microsoft.Testing.Extensions.CtrfReport.csproj	Links ReportEngineContext.cs into CtrfReport extension build
src/Platform/Microsoft.Testing.Extensions.CtrfReport/CtrfReportGenerator.cs	Uses CreateEngineContext(...) to construct CtrfReportEngine
src/Platform/Microsoft.Testing.Extensions.CtrfReport/CtrfReportEngine.cs	Adds a context-taking constructor delegating to ReportEngineBase
src/Platform/Microsoft.Testing.Extensions.TrxReport/Microsoft.Testing.Extensions.TrxReport.csproj	Links ReportEngineContext.cs so ReportEngineBase continues to compile after new ctor overload
src/Platform/Microsoft.Testing.Extensions.VideoRecorder/FfmpegVideoRecorder.cs	Converts recorder to partial and removes extracted concerns from the main file
src/Platform/Microsoft.Testing.Extensions.VideoRecorder/FfmpegVideoRecorder.ProcessManagement.cs	Extracts ffmpeg process/args/exe-discovery code into its own partial file
src/Platform/Microsoft.Testing.Extensions.VideoRecorder/FfmpegVideoRecorder.WindowCapture.cs	Extracts Windows window-region capture + P/Invoke into its own partial file
src/Platform/Microsoft.Testing.Extensions.VideoRecorder/VideoSegment.cs	Extracts VideoSegment struct into its own file
src/Adapter/MSTest.TestAdapter/buildTransitive/common/MSTest.TestAdapter.targets	Adds Returns="@(MSTestV2Files)" to make target output contract explicit
src/Adapter/MSTest.TestAdapter/buildTransitive/uwp/MSTest.TestAdapter.targets	Adds Returns="@(MSTestV2Files)" to make target output contract explicit
Directory.Packages.props	Removes _ValidateBundledSdkFeatureVersions target from .props, updates comment to point to new location
Directory.Build.targets	Adds _ValidateBundledSdkFeatureVersions target in the correct .targets file

Review details

• Files reviewed: 27/27 changed files
• Comments generated: 1
• Review effort level: Low

[Copilot]

Review details

• Files reviewed: 8/8 changed files
• Comments generated: 4
• Review effort level: Low

[Copilot]

Review details

• Files reviewed: 9/9 changed files
• Comments generated: 0 new
• Review effort level: Low

[Evangelink]

🧪 Test quality grade — PR #9487

Δ	Test	Grade	Band	Notes
new	AnalyzerCategoryGovernanceTests. AvoidThreadSleepAndTaskWaitInTests_ UsesPerformanceCategory	A	90–100	No issues found.
new	AnalyzerCategoryGovernanceTests. UseParallelizeAttribute_ MainRule_ UsesPerformanceCategory	A	90–100	No issues found.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 210.6 AIC · ⌖ 14 AIC · ⊞ 43.8K · [◷]( · ◷)