Repository navigation
feat(render): style screenshots and recordings from the config, per profile #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ayman Bagabas (aymanbagabas)
wants to merge
36
commits into
main
Choose a base branch
from
aymanbagabas/recording-style
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
911f18d
feat(config): allow a profile to carry its own recording settings
aymanbagabas 6aff0f9
feat(render): describe how output is drawn as a Style
aymanbagabas c81cbd9
refactor(render): draw from a Style instead of constants
aymanbagabas 66280d0
fix(config): validate and anchor a profile's recording table
aymanbagabas 3e149f6
fix(render): make a Style express only what can be drawn
aymanbagabas 302b680
feat(config): style screenshots and recordings from a profile
aymanbagabas 92ceba6
fix(render): bound what a config can ask the renderers to draw
aymanbagabas eb2ff5b
test(render): prove a configured style reaches the picture
aymanbagabas 4ae1325
feat(render): inherit a profile's style key by key and draw the border
aymanbagabas f65494a
feat(render): draw with the fonts a config names
aymanbagabas f3dc055
refactor(render): name the canvas background and padding for the canvas
aymanbagabas dcedf17
docs(cli): write down how a recording is styled
aymanbagabas cdd9df7
fix(render): bound the font files a config can ask to be read
aymanbagabas eb24bbf
docs: show what the style options look like
aymanbagabas 3ceeb40
docs: show the style options and how recordings look
aymanbagabas 246a322
feat(render): let each gap around the window differ
aymanbagabas 8ef0d14
feat(render): make the gap inside the window configurable too
aymanbagabas ba7f2fd
docs: show the option gallery at one scale
aymanbagabas e55d337
docs: name the default gaps and show them removed
aymanbagabas c5c8820
Merge remote-tracking branch 'origin/main' into aymanbagabas/recordin…
aymanbagabas e92a3f7
fix(config): let a profile be named by the name the flag defaults to
aymanbagabas 10b411a
docs: show a profile overriding the file's recording settings
aymanbagabas ed06668
Merge remote-tracking branch 'origin/main' into aymanbagabas/recordin…
aymanbagabas 3720f19
Merge remote-tracking branch 'origin/main' into aymanbagabas/recordin…
aymanbagabas b34a049
test(bindings): follow the default gap the renderer now draws
aymanbagabas fa88f28
test(render): regenerate the render snapshots for the new gap
aymanbagabas 211b7cb
Merge remote-tracking branch 'origin/main' into aymanbagabas/recordin…
aymanbagabas 4261e39
docs: drop the recording mode a profile can no longer set
aymanbagabas db6edab
docs(style): describe the path a style actually takes
aymanbagabas c8df2b1
ci: run the tests that are behind the recording feature
aymanbagabas 523c19b
Merge remote-tracking branch 'origin/main' into aymanbagabas/recordin…
aymanbagabas 8f44da0
fix(render): address recording style review feedback
aymanbagabas 182727e
fix(render): use the configured bold font for SVG titles
aymanbagabas c7d71c3
docs: center the recording style example
aymanbagabas 3e7925c
Merge remote-tracking branch 'origin/main' into aymanbagabas/recordin…
aymanbagabas 07ca431
fix(go): initialize recording styles in native options
aymanbagabas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.