Skip to content

Wire make ruff into CI / make all #319

Description

Context

#299 added a make ruff target (ruff check, scoped to F403/F405 — banning wildcard imports per AGENTS.md's "Python Import Style Guidelines") but intentionally did not wire it into make all or CI, following the staged approach from #116 ("make a small PR that allows us to run make ruff, adding it to CI is a separate step").

robgruen asked in PR #299 review whether we should track this as a follow-up — this issue is that tracking item.

Scope

  • Add make ruff to the make all target (alongside format/check/test/build).
  • Wire make ruff into the CI workflow(s) so wildcard-import regressions are caught automatically, not just via local make ruff runs.
  • src/typeagent/knowpro/interfaces.py's sanctioned re-export aggregator is already carved out via [tool.ruff.lint.per-file-ignores], so no additional exceptions should be needed for that.

Non-goals

Broader ruff adoption (e.g. as an isort/black replacement) is out of scope — that was discussed and deferred in #116.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions