fix mock NMR deregister race. - #319
Open
shankarseal wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6e257781-cd5a-4ae3-9943-0c217ccad54e
shankarseal
force-pushed
the
shankarseal-fix-nmr-deregister-race
branch
from
August 3, 2026 08:52
2d4b365 to
7d63080
Compare
mikeagun
reviewed
Aug 4, 2026
| std::atomic<size_t> provider_iterations{0}; | ||
| std::atomic<size_t> client_iterations{0}; | ||
|
|
||
| std::thread provider_thread([iteration_count, &provider_iterations]() { |
Contributor
There was a problem hiding this comment.
Should we have some sort of synchronization to ensure the provider and client actually overlap, or at least counter(s) so we can review how much potential contention there was?
My concern is that in CI one thread could complete its iterations before the second thread starts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing