Skip to content

Support custom registries in commands - #93

Open
autoantwort wants to merge 10 commits into
microsoft:mainfrom
autoantwort:support-custom-registries
Open

autoantwort wants to merge 10 commits into
microsoft:mainfrom
autoantwort:support-custom-registries

Conversation

@autoantwort

@autoantwort autoantwort commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Same as #90 but rebased

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see these changed first, then we can look at the resulting code and see what it looks like

Comment thread include/vcpkg/vcpkgpaths.h Outdated
Comment thread src/vcpkg/vcpkgpaths.cpp Outdated
@strega-nil-ms nicole mazzuca (strega-nil-ms) added the depends:different-pr This PR depends on a different PR which has been filed label Jul 2, 2021
@strega-nil-ms

Copy link
Copy Markdown
Contributor

Depends on #105

@autoantwort
autoantwort force-pushed the support-custom-registries branch from db751da to 126641c Compare July 2, 2021 18:33
@autoantwort
autoantwort force-pushed the support-custom-registries branch from 126641c to d3d21c6 Compare July 2, 2021 18:44
Comment thread azure-pipelines/end-to-end-tests-dir/versions.ps1 Outdated
Comment thread include/vcpkg/vcpkgpaths.h Outdated
Comment thread include/vcpkg/vcpkgpaths.h Outdated
Comment thread src/vcpkg-test/arguments.cpp
Comment thread src/vcpkg/vcpkgpaths.cpp Outdated
@theblackunknown

Copy link
Copy Markdown

As a maintainer of a custom registry this PR definitely looks interesting !
Is there anything I can do to help move it forward ?

@autoantwort

Copy link
Copy Markdown
Contributor Author

First microsoft/vcpkg#18967 must be "resolved" and then it can be implemented

@theblackunknown

Copy link
Copy Markdown

I understand, I'll follow the discussion there to keep an eye on this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants