Support custom registries in commands - #93
Open
autoantwort wants to merge 10 commits into
Open
autoantwort wants to merge 10 commits into
autoantwort wants to merge 10 commits into
Conversation
autoantwort
force-pushed
the
support-custom-registries
branch
from
June 14, 2021 20:50
9cda6a2 to
295e3e7
Compare
nicole mazzuca (strega-nil-ms)
suggested changes
Jun 25, 2021
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
I'd like to see these changed first, then we can look at the resulting code and see what it looks like
Contributor
|
Depends on #105 |
autoantwort
force-pushed
the
support-custom-registries
branch
from
July 2, 2021 18:33
db751da to
126641c
Compare
…builtin ports/versions dirs
autoantwort
force-pushed
the
support-custom-registries
branch
from
July 2, 2021 18:44
126641c to
d3d21c6
Compare
autoantwort
force-pushed
the
support-custom-registries
branch
from
July 2, 2021 20:56
2b0efc6 to
c02a947
Compare
|
As a maintainer of a custom registry this PR definitely looks interesting ! |
Contributor
Author
|
First microsoft/vcpkg#18967 must be "resolved" and then it can be implemented |
|
I understand, I'll follow the discussion there to keep an eye on this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #90 but rebased