Handle unknown checks case#8827
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #8813 by ensuring the PR tree does not show an “All checks passed” (green) decoration when the extension can’t reliably determine branch-protection / checks status (i.e., checks are missing or reported as unknown).
Changes:
- Introduces an
UnsatisfiedChecks.Unknownbit to represent “status could not be determined”. - Updates PR tree status computation to set
Unknownwhen checks are unavailable/unknown and no other unsatisfied condition is detected. - Updates status-decoration mapping to account for the new
Unknownflag.
Show a summary per file
| File | Description |
|---|---|
| src/view/prsTreeModel.ts | Sets UnsatisfiedChecks.Unknown instead of treating missing/unknown checks as “no unsatisfied checks”. |
| src/github/utils.ts | Adds UnsatisfiedChecks.Unknown to the bitmask enum. |
| src/github/markdownUtils.ts | Adds handling for UnsatisfiedChecks.Unknown in getStatusDecoration. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Low
benibenj
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8813