Repository navigation
Correct DCompositionGetStatistics array-count metadata - #2387
Open
Jevan Saks (jevansaks) with Copilot wants to merge 4 commits into
Open
Jevan Saks (jevansaks) with Copilot wants to merge 4 commits into
Jevan Saks (jevansaks) with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: jevansaks <20667023+jevansaks@users.noreply.github.com>
Co-authored-by: jevansaks <20667023+jevansaks@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix DCompositionGetStatistics metadata CountFieldName usage
Correct DCompositionGetStatistics array-count metadata
Oct 26, 2026
Co-authored-by: jevansaks <20667023+jevansaks@users.noreply.github.com>
Jevan Saks (jevansaks)
marked this pull request as ready for review
October 26, 2026 04:28
Jevan Saks (jevansaks)
requested review from
a team and
Vineeth Thomas Alex (vineeththomasalex)
as code owners
October 26, 2026 04:28
📋 API Surface Diff+1 additions / -1 deletions vs main branch (full validation run) Click to expand API diffdiff --git "a/bin\\baseline.apidump.cs" "b/bin\\current.apidump.cs"
index bc6e749a..652dc7b5 100644
--- "a/bin\\baseline.apidump.cs"
+++ "b/bin\\current.apidump.cs"
@@ -176973,7 +176973,7 @@ public static class Apis
[DllImport ("dcomp.dll", ExactSpelling = true, PreserveSig = false)]
[Documentation ("https://learn.microsoft.com/windows/win32/api/dcomp/nf-dcomp-dcompositiongetstatistics")]
- public unsafe static extern HRESULT DCompositionGetStatistics ([In] ulong frameId, [Out] COMPOSITION_FRAME_STATS* frameStats, [In] uint targetIdCount, [Optional][Out][NativeArrayInfo (CountFieldName = "targetIdCount")] COMPOSITION_TARGET_ID* targetIds, [Optional][Out] uint* actualTargetIdCount);
+ public unsafe static extern HRESULT DCompositionGetStatistics ([In] ulong frameId, [Out] COMPOSITION_FRAME_STATS* frameStats, [In] uint targetIdCount, [Optional][Out][NativeArrayInfo (CountParamIndex = 2)] COMPOSITION_TARGET_ID* targetIds, [Optional][Out] uint* actualTargetIdCount);
[DllImport ("dcomp.dll", ExactSpelling = true, PreserveSig = false)]
public unsafe static extern HRESULT DCompositionGetTargetStatistics ([In] ulong frameId, [In][Const] COMPOSITION_TARGET_ID* targetId, [Out][RetVal] COMPOSITION_TARGET_STATS* targetStats);
|
Jevan Saks (jevansaks)
enabled auto-merge (squash)
October 26, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DCompositionGetStatistics::targetIdsincorrectly usesCountFieldNameto reference thetargetIdCountparameter.targetCounttotargetIdCount.[NativeArrayInfo(CountParamIndex = 2)].CountFieldName.