Fix cpprest checked iterator build error#6301
Open
Trenly wants to merge 2 commits into
Open
Conversation
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
Could you add a note about this new patch to the overlay README, please? And also a comment somewhere about what the patch is about. |
florelis
approved these changes
Jun 23, 2026
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8 tasks
florelis
requested changes
Jun 26, 2026
Comment on lines
563
to
+565
| New-PortOverlay cpprestsdk -Version 2.10.18 -PortVersion 4 | ||
| # stdext::checked_array_iterator was removed in VS2026 (MSVC 19.43); replace with plain pointers. | ||
| Add-LocalPatch cpprestsdk 'fix-msvc-checked-array-iterator.patch' |
Member
There was a problem hiding this comment.
Looks like there is already a fix in the official port: microsoft/vcpkg#51750
Instead of applying our own patch, we could just update the version we use.
Suggested change
| New-PortOverlay cpprestsdk -Version 2.10.18 -PortVersion 4 | |
| # stdext::checked_array_iterator was removed in VS2026 (MSVC 19.43); replace with plain pointers. | |
| Add-LocalPatch cpprestsdk 'fix-msvc-checked-array-iterator.patch' | |
| New-PortOverlay cpprestsdk -Version 2.10.19 -PortVersion 5 |
While looking this up, I learned that cpprestsdk is now delisted from vcpkg (microsoft/vcpkg#52130) because the repo was archived. So maybe we'll have to figure out something else to use at some point.
microsoft-github-policy-service
Bot
added
the
Needs-Author-Feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Adds a patch for
cpprestsdkto allow it to build in VS2026 18.5.3🔗 References
🔍 Validation
Built locally
✅ Checklist
📋 Issue Type
Microsoft Reviewers: Open in CodeFlow