Skip to content

OADP-7895 Fix for the oc oadp nonadmin backup describe shows Pod Volu… - #262

Open
SharoonAustin06 wants to merge 1 commit into
migtools:oadp-devfrom
SharoonAustin06:OADP-7895
Open

SharoonAustin06 wants to merge 1 commit into
migtools:oadp-devfrom
SharoonAustin06:OADP-7895

Conversation

@SharoonAustin06

Copy link
Copy Markdown

Why the changes were made

For the non-admin command whenever we are describing the backup it simply returns a static string, with these changes we have made it dynamic.

How to test the changes made

Create a non-admin backup for the non-admin user and try to use the oadp nonadmin describe commands with and without details flag.

@openshift-ci
openshift-ci Bot requested review from sseago and weshayutin September 3, 2026 06:58
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 639986bf-0c6c-4cb7-8eb3-b24eb3d529b6


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown

Hi @SharoonAustin06. Thanks for your PR.

I'm waiting for a migtools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread cmd/non-admin/backup/describe.go Outdated
Comment thread cmd/non-admin/backup/describe.go Outdated
Comment thread cmd/non-admin/backup/describe.go
Comment thread go.mod Outdated
@SharoonAustin06
SharoonAustin06 force-pushed the OADP-7895 branch 2 times, most recently from 42983d1 to d5ac56d Compare September 7, 2026 11:54
Comment thread cmd/non-admin/backup/describe_test.go Outdated
Comment thread cmd/non-admin/backup/describe_test.go Outdated
Comment thread cmd/non-admin/backup/describe_test.go Outdated
@SharoonAustin06
SharoonAustin06 force-pushed the OADP-7895 branch 2 times, most recently from 954dd0f to e685235 Compare September 11, 2026 05:21

@shubham-pampattiwar shubham-pampattiwar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shubham-pampattiwar

Copy link
Copy Markdown
Member

/cherry-pick oadp-1.6

@openshift-cherrypick-robot

Copy link
Copy Markdown

@shubham-pampattiwar: once the present PR merges, I will cherry-pick it on top of oadp-1.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shubham-pampattiwar

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Sep 16, 2026
@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SharoonAustin06, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sseago

sseago commented Sep 16, 2026

Copy link
Copy Markdown

/retest

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

@SharoonAustin06: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 30c8996 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SharoonAustin06

Copy link
Copy Markdown
Author

/retest-required

@openshift-ci

openshift-ci Bot commented Sep 17, 2026

Copy link
Copy Markdown

@SharoonAustin06: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants