Skip to content

RFE-9751: Add non-admin backup schedules - #385

Draft
shubham-pampattiwar wants to merge 1 commit into
migtools:oadp-devfrom
shubham-pampattiwar:rfe-9751-nonadminschedule
Draft

shubham-pampattiwar wants to merge 1 commit into
migtools:oadp-devfrom
shubham-pampattiwar:rfe-9751-nonadminschedule

Conversation

@shubham-pampattiwar

@shubham-pampattiwar shubham-pampattiwar commented Sep 16, 2026

Copy link
Copy Markdown
Member

Why the changes were made

Implements RFE-9751 by adding tenant-scoped NonAdminSchedule resources. Each NAS creates a controlled backing Velero Schedule, surfaces each generated Backup as a synchronized NonAdminBackup, preserves the tenant BSL mapping per run, and removes synchronized NABs after their backing Backup expires. The committed design is in docs/design/nonadmin_schedule.md.

How to test the changes made

  • GOCACHE=/private/tmp/rfe9751-gocache-elevated GOTMPDIR=/private/tmp/rfe9751-gotmp-elevated go test ./internal/controller -count=1
  • GOCACHE=/private/tmp/rfe9751-gocache-elevated GOTMPDIR=/private/tmp/rfe9751-gotmp-elevated go test ./... -run "^TestNonAdminSchedule|^TestNextRun" -count=1
  • GOCACHE=/private/tmp/rfe9751-gocache-elevated GOTMPDIR=/private/tmp/rfe9751-gotmp-elevated go vet ./...

Add the NonAdminSchedule API and controller to manage tenant-scoped scheduled backups through backing Velero Schedules.

🤖 Generated with [Codex](https://Codex.com/Codex)

Co-Authored-By: Codex <noreply@anthropic.com>
@openshift-ci-robot

openshift-ci-robot commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

@shubham-pampattiwar: This pull request references RFE-9751 which is a valid jira issue.

Details

In response to this:

Why the changes were made

Implements RFE-9751 by adding tenant-scoped NonAdminSchedule resources. Each NAS creates a controlled backing Velero Schedule, surfaces each generated Backup as a synchronized NonAdminBackup, preserves the tenant BSL mapping per run, and removes synchronized NABs after their backing Backup expires. The committed design is in docs/design/nonadmin_schedule.md.

How to test the changes made

  • GOCACHE=/private/tmp/rfe9751-gocache-elevated GOTMPDIR=/private/tmp/rfe9751-gotmp-elevated go test ./internal/controller -count=1
  • GOCACHE=/private/tmp/rfe9751-gocache-elevated GOTMPDIR=/private/tmp/rfe9751-gotmp-elevated go test ./... -run "^TestNonAdminSchedule|^TestNextRun" -count=1
  • GOCACHE=/private/tmp/rfe9751-gocache-elevated GOTMPDIR=/private/tmp/rfe9751-gotmp-elevated go vet ./...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Sep 16, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shubham-pampattiwar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oadp-snyk

oadp-snyk commented Sep 16, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants