Repository navigation
Use transparent, theme-selected browser favicons - #74
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f29980810
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }; | ||
| update(); | ||
| document.head.append(icon); | ||
| appearance.addEventListener("change", update); |
There was a problem hiding this comment.
On older Safari/WebKit versions that support prefers-color-scheme but expose only MediaQueryList.addListener, this unconditional call throws after installing the initial icon, so later appearance changes never update it. The repository already handles this compatibility case in site/build-site.mjs:6305-6308; use the same addEventListener/addListener fallback here and cover the legacy listener shape in the controller test.
Useful? React with 👍 / 👎.
This branch was successfully deployed
1 participant
Dark favicon tiles develop a white outline in Safari. Use transparent canonical marks in both browser themes and one typed ICO selected by a synchronous head controller before parsing finishes. Retain published icon URLs as explicit aliases to the current assets.
Validation: focused asset and site tests, real Chromium initial-theme/cardinality/change/no-script cases, deterministic exports, and production build passed. Canonical artwork, headers, sharing cards, and opaque installation icons remain unchanged. Native Safari background and theme-selection controls informed the change; an existing native favicon cache can still retain older processed artwork.