Repository navigation
chore: replace Biome with Oxfmt and Oxlint - #33
Merged
Merged
Conversation
Several release control tests accept any failure. The publication checks
search the whole error message, which also contains the script text with
every expected `::error::` line, and the tag checks accept any rejection
or the fixture's own catch-all error.
Assert the exact error each failing step reports, matching printed
annotations from the start of an output line, and make the tag fixture
fail the history check explicitly.
release:
- Anchor publication step errors to the annotation line they print.
- Assert the exit status of steps that fail without output.
- Assert the exact tag verification failures, including a synthetic
history check failure.
The JavaScript tooling ecosystem is adopting Oxc, and the maintainers'
other projects are moving their formatting and linting to it. Staying on
Biome here would keep a separate toolchain, configuration, and editor
setup to maintain.
Replace it with Oxfmt for formatting and Oxlint with type-aware rules
for linting, keep the rules Biome enforced, and adapt the code and tests
to the stricter checks.
repository:
- Format TypeScript, JSON, Markdown, and YAML with Oxfmt, keeping the
previous line width and import grouping.
- Sort the top-level keys of the package manifest with the formatter.
- Lint with the correctness, suspicious, perf, and pedantic categories
plus Oxlint equivalents of Biome's recommended rules.
- Give extension host tests a nested TypeScript project so type-aware
rules resolve their Mocha types.
- Run both tools through the existing check, fix, and format scripts.
- Describe the new tools in the agent guide and the coding style
skill.
- Adjust sources to the new rules without changing behavior.
- Type test mocks with their real contracts and assert the exact
errors thrown.
- Read registered callbacks from mocks instead of no-op placeholders.
- Run the packed CLI's signal check as its own POSIX-only test.
devcontainer:
- Use the Oxc extension for formatting and fixes on save.
extension:
- Mark the queue poll interval callback as intentionally unawaited.
release:
- Validate GitHub response chunks before counting them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JavaScript tooling ecosystem is adopting Oxc, and the maintainers'
other projects are moving their formatting and linting to it. Staying on
Biome here would keep a separate toolchain, configuration, and editor
setup to maintain. Separately, several release control tests accept
any failure: the publication checks search the whole error message,
which also contains the script text with every expected
::error::line, and the tag checks accept any rejection or the fixture's own
catch-all error.
Replace Biome with Oxfmt for formatting and Oxlint with type-aware rules
for linting, keep the rules Biome enforced, and adapt the code and tests
to the stricter checks. Assert the exact errors the release controls
report.
repository:
previous line width and import grouping.
plus Oxlint equivalents of Biome's recommended rules.
rules resolve their Mocha types.
skill.
errors thrown.
devcontainer:
extension:
release:
history check failure.