Skip to content

Re-lay out the fixtures under ns/<namespace>/; the re-founding note (issue 9) - #163

Open
Hafeok wants to merge 2 commits into
claude/great-feynman-zcdsdd-step-08-close-everywherefrom
claude/great-feynman-zcdsdd-step-09-fixtures
Open

Hafeok wants to merge 2 commits into
claude/great-feynman-zcdsdd-step-08-close-everywherefrom
claude/great-feynman-zcdsdd-step-09-fixtures

Conversation

@Hafeok

@Hafeok Hafeok commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Closes #152 — PRD ledger/prd/namespace-independence-prd.md §6 issue 9 (§3.11; rulings 63 and 68).

Stacked on #162 (issue 8). Review the last commit alone, 011a7218.

What lands

The fifteen committed fixture stores under ledger-cli/tests/fixtures/ move their sets/ and log/ under .decisions/ns/<namespace>/ with git mv — fixture.ledger for the twelve class fixtures and pass, and fixture.coverage, fixture.forked, fixture.two-clocks for the rest. No file's content changed: UPDATE_FIXTURES=1 cargo test -p ledger-cli --test gate finds nothing to refresh (checked: no fixture file modified after the run).

The staging shim issue 1 left in the test helpers goes: stage_fixture, stage_fixture_into, stage_workspace and the flat branch of stage_store_into become plain copies (fixture_copy, copy_fixture_into, workspace_copy, copy_store_into); the flat fallbacks in gate.rs's and digests.rs's fixture walkers go. legacy_layout.rs lays the pass fixture flat itself, byte for byte, to build its v1.8 history; scalars.rs reads the fixture's set from its namespace directory.

The tests of §3.11: item 1 (flat paths) was done by issue 1, with the shim removed here; item 2 (meaning changed under rulings 47 and 68) by issues 5, 6 and 8; item 3 (the flat era in history) by issue 2; item 4 (D6 by landing) is issue 12's. A grep over the test sources finds no flat path left.

Protocol

The Appendix C note "Namespaces become independent; a store with shared authority is re-founded" lands as the PRD drafted it, headed with no format number (no format bump happens in this series; the draft said "and format 8" — noted in the note's last line); the v1.9 note's two sentences that pointed at this issue now point at the note and at the fixtures; Appendix B row. No class added; no digest moves.

Checks

cargo build, cargo t, cargo clippy --workspace -- -D warnings -D clippy::unwrap_used, the quality scripts, and ledger verify --export on this repository (same output as on main).

🤖 Generated with Claude Code

https://claude.ai/code/session_01GgRcHXmnAu43hChNxhnqxU


Generated by Claude Code

Hafeok commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator Author

CI, standing down on one step. The check job failed at the contract-surface gate (ddd diff-contracts ccf8a0c3..HEAD) and nowhere else: 8 undischarged events, all in ledger-cli/tests/common/mod.rs — the four staging-shim helpers removed (stage_fixture, stage_fixture_into, stage_store_into, stage_workspace) and the four copy helpers that replace them (fixture_copy, copy_fixture_into, copy_store_into, workspace_copy). Every step before it passed on this head: the workspace build, cargo t, clippy, the code-quality gates, the spec flow, ledger verify --export (conformant, every committed export matching byte for byte) and ddd validate.

The remedy the gate names is ddd bind claude/great-feynman-zcdsdd-step-08-close-everywhere..HEAD (with --verdict), which files seam declarations under .ddd/seams/. The session's instructions forbid me to edit .ddd/, and a declaration's verdict is the author's judgment, so I am not filing them. Please run ddd bind on this branch and push, or tell me to. Recorded in the close-out (#164, §4).


Generated by Claude Code

Hafeok added a commit that referenced this pull request Oct 9, 2026
@Hafeok
Hafeok force-pushed the claude/great-feynman-zcdsdd-step-08-close-everywhere branch from ccf8a0c to 0fafebc Compare October 11, 2026 06:20
@Hafeok
Hafeok force-pushed the claude/great-feynman-zcdsdd-step-09-fixtures branch from 011a721 to 72cebea Compare October 11, 2026 06:22
@Hafeok
Hafeok force-pushed the claude/great-feynman-zcdsdd-step-08-close-everywhere branch from 0fafebc to f85d4d5 Compare October 11, 2026 06:22
@Hafeok
Hafeok force-pushed the claude/great-feynman-zcdsdd-step-09-fixtures branch from 72cebea to 7766d21 Compare October 11, 2026 06:22
Hafeok added a commit that referenced this pull request Oct 11, 2026
Hafeok and others added 2 commits October 11, 2026 06:29
Issue #152 (PRD issue 9, §3.11; rulings 63 and 68). The fifteen
committed fixture stores under `ledger-cli/tests/fixtures/` move their
`sets/` and `log/` under `.decisions/ns/<namespace>/` with `git mv` —
`fixture.ledger` for the twelve class fixtures and `pass`,
`fixture.coverage`, `fixture.forked`, `fixture.two-clocks` for the rest
— no file's content changed, and `UPDATE_FIXTURES=1 cargo test -p
ledger-cli --test gate` finds nothing to refresh (checked: no fixture
file modified).

The staging shim issue 1 left in the test helpers goes: `stage_fixture`,
`stage_fixture_into`, `stage_workspace` and the flat branch of
`stage_store_into` become plain copies (`fixture_copy`,
`copy_fixture_into`, `workspace_copy`, `copy_store_into`), and the flat
fallbacks in `gate.rs`'s and `digests.rs`'s fixture walkers go.
`legacy_layout.rs` lays the `pass` fixture flat itself, byte for byte,
to build its v1.8 history; `scalars.rs` reads the fixture's set from its
namespace directory.

The tests of §3.11: item 1 (flat paths) was done by issue 1, with the
shim removed here; item 2 (meaning changed under rulings 47 and 68) by
issues 5, 6 and 8; item 3 (the flat era in history) by issue 2; item 4
(D6 by landing) is issue 12's. A grep over the test sources finds no
flat path left.

Protocol: the Appendix C note "Namespaces become independent; a store
with shared authority is re-founded" lands as the PRD drafted it, headed
with no format number (no format bump here; the draft said "and format
8"); the v1.9 note's two sentences that pointed at this issue now point
at the note and at the fixtures; Appendix B row. No class added; no
digest moves.

Stacked on #162 (issue 8).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GgRcHXmnAu43hChNxhnqxU
Files the signed bindings the contract-surface gate demands for this
step's eight exposed Rust surface changes, all test helpers in
ledger-cli/tests/common/mod.rs: the four staging-shim helpers removed and
the four copy helpers that replace them.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GgRcHXmnAu43hChNxhnqxU
@Hafeok
Hafeok force-pushed the claude/great-feynman-zcdsdd-step-08-close-everywhere branch from f85d4d5 to 5f23b62 Compare October 11, 2026 06:29
@Hafeok
Hafeok force-pushed the claude/great-feynman-zcdsdd-step-09-fixtures branch from 7766d21 to a3f3d54 Compare October 11, 2026 06:29
Hafeok added a commit that referenced this pull request Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant