feat: redirect to submission page after successful submit - #164
Merged
Merged
Conversation
submitSolution now returns the new submissionId from the API response; both task and contest submission forms navigate to the submission detail page after success (in addition to refreshing the task). - closes #135
goto was called unawaited after onSuccess (task refresh); the re-render could cancel the pending navigation. Navigate first, then refresh.
- createParameterizedQuery skips fetch for non-finite numeric params (prevents /contests/NaN/tasks/NaN 400 during hydration/navigation) - explicit guards in contest + contest-task pages - TestCaseResult handles null executionTimeMs/peakMemoryKb (fresh submissions have null values -> toFixed crash)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #135.
Changes
SubmissionService.submitSolutionnow parsessubmissionIdfrom the API response/dashboard/user/submissions/{id}after success (keeps existing task refresh viaonSuccess)Verification
pnpm run check→ 0 errorspnpm run buildsucceeds