fix: contest results page and past-contest view details button - #166
Merged
Merged
Conversation
- participant results page now renders only the current user's task
results from /contests/{id}/results/my (removed broken leaderboard that
relied on fields the endpoint never returns)
- PastContestCard 'View Details' button now links to the results page
(was a no-op button without href)
- closes #133
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133.
Changes
/user/contests/[contestId]/results): now renders only the current user's own task results from/contests/{id}/results/my. Previously it rendered a leaderboard + summary cards driven bymyResults/leaderboardfields that this endpoint never returns — participants saw an empty state.Verification
pnpm run buildsucceeds