fix: infinite request loop on user profile page - #168
Merged
Merged
Conversation
The dashboard layout renders a spinner while userStore.isLoading() and only mounts page content once a user is loaded. The profile page's createQuery called getCurrentUser() which sets userStore.loading=true -> layout swaps to spinner -> page unmounts -> loading resolves false -> page remounts -> createQuery refetches -> loading=true ... infinite loop, hitting the API until rate-limited. Profile now reads the already-loaded user from userStore (the dashboard layout guarantees it exists) instead of re-fetching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Opening the user profile page fired an endless stream of
/users/merequests until the API rate-limited the client.Root cause
Infinite loop between two components:
dashboard/+layout.svelterenders a spinner whileuserStore.isLoading()and only mounts page content after a user is loaded.profile/+page.svelteusedcreateQuerycallinggetCurrentUser(), which setsuserStore.loading = trueat the start of the fetch.Sequence: page mounts →
createQueryfetches →loading=true→ layout swaps to spinner → page unmounts → fetch completes →loading=false→ layout renders page → remount →createQueryruns again → loop.Fix
Profile page reads the already-loaded user from
userStore(guaranteed present by the dashboard layout guard) instead of issuing its owngetCurrentUserfetch.Verification
pnpm run buildsucceeds