fix(rust): gate Windows-only font alias helpers behind cfg(windows) - #195
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe font alias helpers and their test import now compile only on Windows. ChangesFont alias platform gating
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Crates.io Publish workflow failed at its Lint step (
cargo clippy -D warnings) because three font-alias helpers incrates/minipdf/src/fonts.rsare only used from the Windows-only cloud-font registration path. On the Ubuntu runner they are dead code.Changes
font_alias_from_data,build_font_alias, andnormalize_font_aliasbehind#[cfg(target_os = "windows")].builds_stable_cloud_font_aliasestest and its import the same way.Validation
cargo clippy --workspace --all-targets --locked -- -D warningspasses.cargo test --workspace --lockedpasses (112 lib tests + CLI tests).Summary by CodeRabbit