Repository navigation
Drop libraries="hub" and settle auto-resize before 1.0 - #45
Merged
Merged
Conversation
`hub` has been read as `pack` since player 0.6. Kept into 1.0 it would have had to stay through 1.x, so the element, the embed site and the verifier stop special-casing it: it is a word like any other, a URL relative to the page, and a page still writing it fails with an error naming that address. A bare `auto-resize` is no alias, since anything but `off` means on, so it leaves the deprecation list and our own pages stop writing it. The README's API table names the `saveInterval` property, and loses a runtime note the peer range already enforces. BREAKING CHANGE: libraries="hub" (element), &libraries=hub and --default-libraries hub (embed), --libraries hub (verify) no longer mean the pack. Write pack. Closes #44 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44.
1.0 freezes the API, and Deprecation in
docs/compatibility.mdlisted two forms that would then have stayed through all of 1.x. This takes both off the list.Changes
hubis no longer special. The element'sparseLibrarySourcesdrops it and the console note. The embed command's--default-libraries, the embed page's&libraries=and the verifier's--librariesall drop it too. Written now,hubis a word like any other: the element reads it as a URL relative to the page, the embed command refuses it (not pack, none or a URL: hub), and the verifier looks for a file namedhuband says there is none.auto-resizecomes off the deprecation list. It was never an alias in the code: the element follows the content's height unless the value isoff, so the bare attribute means "on" like any boolean attribute and will never go. The embed site's page, the verifier's page and the demo's/embedstopped writing it, since it suggested the attribute was needed.save-intervalrow names its property,saveInterval. Theuntrustedrow drops "Needs the runtime at 0.2 or later", which the player's peer range (^0.2.0) already covers;docs/untrusted.mdstill explains the fail-closed check for an older runtime.docs/libraries.md,docs/privacy.md,docs/compatibility.md("None is in that state now"), the setup skill, the demo's setup page, and AGENTS.md.The rest of the API tables were read against the element: every attribute it reads, every public property,
clearUserData(), and each event'sdetailmatch what the README says.Testing
pnpm typecheck, all packages.library-sources.test.tsnow pinshubas a URL andpackwritten twice as tried once.libraries.test.tsandpack.test.tsin Chromium: 30 passed.&libraries=hubto a site locked to a host list was the only check that such a site resolvespackto its own copy, so it now sends&libraries=packrather than going.formulas.h5pwithlibraries="hub"fails withbad-archive: "This package is missing H5P.QuestionSet-1.21, and http://localhost:5199/demo/hub did not supply them: Could not read the archive index". On a static host the address 404s instead. Withlibraries="pack"the same package plays from the pack. No console line nameshubany more.Not run: Firefox and WebKit, and the full browser suite; the change touches only how the attribute is parsed.
Release
Breaking for a page with
libraries="hub", an embed address with&libraries=hub, a site written with--default-libraries hub, and a pipeline running--libraries hub. Each should writepack. The next player, embed and verify releases should list it first. Pre-1.0, so a minor.🤖 Generated with Claude Code