Elect checkpoint-commit representatives by Modal task id - #56
Closed
micahtyong wants to merge 1 commit into
Closed
micahtyong wants to merge 1 commit into
micahtyong wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'DevinAI' or '@devin'.
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multi-node Lilo checkpoints only ever contained node 0's shards, which makes every multi-node run unresumable.
_sync_checkpoint_volume()elects one volume-committing representative per node by hostname:Every Modal cluster container reports the same hostname. Verified with a 2-node
@modal.experimental.clusteredprobe:so
hosts == ["modal"] * world_size, only global rank 0 is ever a representative, and ranks 8+ neverVolume.commit()their.distcpshards. This is what killedlilo-27b-256k-pad-30-1789719362(24 ranks, 3 nodes): checkpoint000018onlilo-checkpointsholds only__0_0.distcp … __7_0.distcp, and all nine chained resume attempts died withFix: identify the node by
MODAL_TASK_ID, which is distinct per cluster container and inherited by the Ray workers the container spawns (same probe:ta-01M330JFS8NWWBTRGYARPT93XRvsta-01M330JFX4Y6528JDRY8D2EM6R, and a child process sees the same value). Falls back to the hostname off Modal.Link to Devin session: https://modal.devinenterprise.com/sessions/ca503f6afb54412498a66f69af517adf
Open in Devin Desktop: https://modal.devinenterprise.com/desktop/session/ca503f6afb54412498a66f69af517adf?variant=devin
Requested by: @micahtyong