Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
micahtyong
approved these changes
Sep 28, 2026
micahtyong
left a comment
Contributor
There was a problem hiding this comment.
looks like you'll need to rebase now that #55 is in but this lgtm
Contributor
|
Closing as superseded by #55, which already contains everything this PR changes:
The only line not on The investigation (Miles radixark/miles#3318 pulling in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes our Qwen Miles LoRA definitions, broken since radixark/miles#3318 (merged 2026-09-23).
Our
TARGET_MODULESuse Megatron selectors (linear_qkv,linear_proj,linear_fc1,linear_fc2). Before #3318, Miles mapped these to HF names with a static table (linear_fc1 -> gate_proj, up_proj, etc.). Since #3318, Miles matches each selector against both the Megatron and the HF name of every module. The Qwen vision tower's HF modules are namedmodel.visual.blocks.N.mlp.linear_fc1/linear_fc2, so they now match too and end up in the adapter.The SGLang rollout pool is launched with
--lora-target-modules = ROLLOUT_LORA_TARGET_MODULES, which only lists LM modules, so it rejects the adapter with a 400 on the first sample.Fix: use the HF names in
TARGET_MODULES, the same names as inROLLOUT_LORA_TARGET_MODULES. These names only exist in the LM.Applies to 9B
16k/16k_dp2, 9B-Base2k/16k, 27B16k/64k/128k/256k.Other changes:
miles_config.py: add the HF names to_ATTN_LEAVES/_MLP_LEAVES/_UNEMBED_LEAVES. These sets aren't passed to Miles.lora_target_flagsuses them to derivetrain_attn/train_mlp/train_unembed, whichcreate_modelchecks against the request. Without this, HF targets would give(False, False, False).TARGET_MODULES ⊆ ROLLOUT_LORA_TARGET_MODULESfor every Miles LoRA definition. It catches lilo-side mismatches (e.g.lm_headadded to only one list), not Miles behavior changes.--exclude-modules model.visual.*doesn't work instead: Miles asserts when an exclusion overlaps an explicit target likelinear_fc1.Link to Devin session: https://modal.devinenterprise.com/sessions/942b72932a7445349a6c123a326c5acd
Open in Devin Desktop: https://modal.devinenterprise.com/desktop/session/942b72932a7445349a6c123a326c5acd?variant=devin
Requested by: @kevintli