Conversation
commit: |
felixweinberger
self-requested a review
September 25, 2026 16:55
felixweinberger
removed their request for review
September 25, 2026 17:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capabilities.extensionscan be lost during SDK serialization or parsing even when the legacy initialize handshake succeeds. This adds coverage for the behavior clarified in modelcontextprotocol/modelcontextprotocol#3364 and defined by SEP-2133.Closes #517.
Changes
legacy-extensions) and one server scenario (server-legacy-extensions), each exercising the 2025-11-25 handshake and capability preservation in both directions.This tests capability preservation on 2025-11-25, not full Apps functionality, all earlier protocol versions, or the newer per-request capability flow. The example.com identifiers are diagnostic fixtures only.
Validation
npm run buildnpm run check(typecheck and lint)npm test: 49 files, 636 tests passedgit diff --checkThe environment blocks the tsx CLI's IPC socket, so local test execution used a node_modules-only launcher adapter invoking
node --import tsx. No dependency, lockfile, or repository script changes are included.AI assistance: Codex prepared and validated this change at Sambhav's request.