Repository navigation
Conversation
ianegordon
added a commit
to ianegordon/swift-sdk
that referenced
this pull request
Sep 11, 2026
The change is correct — Value.init(_:) only ever encodes its argument, so the Codable constraint is over-tight — but it fixes no bug, and unlike every other entry in the manifest its absence upstream is a compile error rather than a runtime fault. Fork code passing an Encodable-only type would not build against upstream unless modelcontextprotocol#227 lands there, turning the return this fork exists to make easy into a build break. No downstream needs the looser constraint today. Moved from the candidate table to 'Not included, and why'. Remaining candidates renumbered 7-10 to 6-9 so the intended order still continues the manifest sequence. modelcontextprotocol#278's note no longer calls itself the second Value.swift edit in the batch, since modelcontextprotocol#227 was the first. Tracking: fork issue #13, relabelled decline. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eb9yGSXH1TVkg5Afsu9phk
ianegordon
added a commit
to ianegordon/swift-sdk
that referenced
this pull request
Sep 11, 2026
The Windows build failure is real — Package.swift provides EventSource only on Apple platforms while HTTPClientTransport.swift imports it behind #if !os(Linux) — and widening the five guards to os(Linux) || os(Windows) is the obvious fix. It is inert on macOS and Linux by inspection. But that it actually fixes Windows cannot be verified here: no Windows machine, and ci.yml runs macos-latest and ubuntu-latest only. Windows is low priority for this fork's downstreams, so an unverifiable patch is not worth the divergence. Cheap to reverse if that changes: unlike modelcontextprotocol#227, this cannot make fork code fail to build against upstream. Moved from the candidate table to 'Not included, and why'. Remaining candidates renumbered 7-9 to 6-8 so the intended order still continues the manifest sequence. Tracking: fork issue #9, relabelled decline. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Eb9yGSXH1TVkg5Afsu9phk
This was referenced Sep 11, 2026
Contributor
|
Hi @samkudr, thanks for this PR! I've reviewed it and it looks good to merge. Could you please rebase it onto the latest If you're no longer able to work on this, no problem: just let us know. If we don't hear back in about two weeks, we may carry the change forward in a new PR, with credit to you. |
Contributor
Author
|
@varun06 I used GitHub interface for rebasing, I hope it did it correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value.init(:)requires its parameter to conform toCodablebut actually it needs justEncodablevalue.Motivation and Context
The current requirement is literally excessive: the initializer encodes the incoming value to
Value, the same wayJSONEncoderencodes the incoming value toData.How Has This Been Tested?
In my project I was forced to extend conformance of some types to
Decodablealso, while knowing that it is never used.Breaking Changes
No.
Types of changes
Checklist
Additional context