Repository navigation
Fix tool input schemas in README examples - #294
Open
EhsanAzish80 wants to merge 1 commit into
Open
EhsanAzish80 wants to merge 1 commit into
EhsanAzish80 wants to merge 1 commit into
Conversation
Contributor
|
Hi @EhsanAzish80, thanks for this PR! I've reviewed it and it looks good to merge. Could you please rebase it onto the latest If you're no longer able to work on this, no problem: just let us know. If we don't hear back in about two weeks, we may carry the change forward in a new PR, with credit to you. |
EhsanAzish80
force-pushed
the
docs/fix-readme-tool-schemas
branch
from
October 22, 2026 15:27
6d5c968 to
42f5c2e
Compare
EhsanAzish80
force-pushed
the
docs/fix-readme-tool-schemas
branch
from
October 22, 2026 16:49
42f5c2e to
70d6da5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weather and calculator examples used description strings where the tool input schema needs property objects. This gives each example an object schema with typed string properties. Related to #128.
Checked both examples and the diff. Documentation only.