Repository navigation
Restore stdio descriptor flags on disconnect - #297
Open
EhsanAzish80 wants to merge 1 commit into
Open
EhsanAzish80 wants to merge 1 commit into
EhsanAzish80 wants to merge 1 commit into
Conversation
Contributor
|
Hi @EhsanAzish80, thanks for this PR! I've reviewed it and it looks good to merge. Could you please rebase it onto the latest If you're no longer able to work on this, no problem: just let us know. If we don't hear back in about two weeks, we may carry the change forward in a new PR, with credit to you. |
EhsanAzish80
force-pushed
the
fix/restore-stdio-descriptor-flags
branch
from
October 22, 2026 15:29
f2d760c to
a0ce641
Compare
EhsanAzish80
force-pushed
the
fix/restore-stdio-descriptor-flags
branch
from
October 22, 2026 16:49
a0ce641 to
3025e14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69. StdioTransport now restores the blocking mode it changed when it disconnects. It waits for reads and sends to finish first, and leaves already nonblocking or reused descriptors alone.
Tests: the regression failed before the fix, 11 stdio tests and all 556 Swift tests passed locally, and the backpressure test passed 10 runs locally.