refactor: infer flags type from options definition in defineCommand#60
Closed
lishengzxc wants to merge 1 commit into
Closed
refactor: infer flags type from options definition in defineCommand#60lishengzxc wants to merge 1 commit into
lishengzxc wants to merge 1 commit into
Conversation
Generify CommandSpec and defineCommand so the `run` callback's `flags` parameter is typed as `GlobalFlags & InferFlags<Options>`, where InferFlags derives typed properties from the command's `options` array. This removes ~150 manual `as string` / `as number` / `as string[]` type assertions across 46 command files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
This issue will be resolved through overall structural adjustments in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generify CommandSpec and defineCommand so the
runcallback'sflagsparameter is typed asGlobalFlags & InferFlags<Options>, where InferFlags derives typed properties from the command'soptionsarray.This removes ~150 manual
as string/as number/as string[]type assertions across 46 command files.