feat(extensions): keyboard commands and additive multi-sidebar views

[benvinegar]

Follow-up to #609. Extensions can now register named keyboard commands and any number of sidebar views, so a user can keep the built-in file navigation, replace it, or open extra panes — left or right of the review stream — from keys their extensions registered.

Keyboard command system

Not a sidebar one-off: every app-level shortcut moved out of the keyboard hook's if-cascade into one named-command dispatch table (src/ui/lib/appCommands.ts — review.nextHunk, view.toggleSidebar, app.quit, ...), and extension registerCommand entries join that same table.

• hunk.registerCommand({ id, title, key }, handler) — chord syntax "ctrl+m", "F2", "G", "["; an unparsable chord fails registration loudly.
• Built-ins keep every key they ship with: conflicts are detected by synthesizing the key event a chord describes and probing every matcher (built-ins match with predicates, so chord comparison alone can't answer), then refused with a warning naming both sides. Between extensions, load order wins.
• Modal surfaces (dialogs, menus, focused inputs) still own their keys first — those are widget structure, not shortcuts.
• Handlers receive ctx.sidebars (open/close/toggle/isOpen), which is how a registered key opens the sidebar its extension contributed.

Additive multi-sidebar

• registerSidebarView now contributes a view instead of replacing: { id, title, placement: "left" | "right", defaultOpen, replacesDefault, component }. replacesDefault stands a view in for the built-in file navigation, which stays available (just closed).
• One pane model (src/ui/lib/sidebarPanes.ts) plans which open panes fit and at what width — narrow terminals drop latest-registered panes first, the review stream keeps its minimum — with per-pane divider resize (right-side dividers invert the drag) and open/closed choices that survive extension reloads.
• A view that fails rendering closes with a warning naming the extension; the built-in file navigation reopens if nothing else is showing.

Coverage

• Chord parse/match/synthesize round-trips (src/lib/commandKeys.test.ts)
• Conflict refusal incl. the built-in s case and between-extension load order (extensionCommands.test.ts)
• Pane planning, open-state reconciliation across reloads, and control-id resolution (sidebarPanes.test.ts)
• registerCommand validation and rollback (runExtension.test.ts)
• AppHost end-to-end: press y → command → sidebar opens beside files → its actions drive selection_changed → y closes it; replacesDefault; crash-close-and-restore
• Live PTY test doing the command-toggle flow against the real app, with the extension pane on the right

check:pack verifies the new docs examples typecheck for consumers. Deliberately not in this pass (the table is built for them — ids, titles, key labels all exist): user-remappable keybindings and menu listings for extension commands.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JML2m7oy2sUbFftN7QoHhi

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hunk-web	Ready	Preview	Jul 28, 2026 2:17am

[greptile-apps]

Greptile Summary

Adds a unified named-command dispatch system and additive multi-pane sidebars for extensions.

• Exposes command registration, key-chord parsing, conflict detection, and sidebar controls through the extension API.
• Refactors built-in keyboard shortcuts into the shared command table while preserving modal and focused-input precedence.
• Adds left/right sidebar planning, per-pane resizing, reload reconciliation, and render-failure recovery.
• Expands unit, AppHost, packaging, and PTY integration coverage.

Confidence Score: 5/5

The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issues identified.

The command dispatch preserves modal and focused-input ownership, sidebar state is reconciled across extension reloads, pane planning protects the review stream minimum width, and extension failures are contained with fallback behavior.

Important Files Changed

Filename	Overview
src/ui/App.tsx	Integrates extension commands, sidebar state, pane planning, resizing, and render-failure recovery into the application shell.
src/ui/hooks/useAppKeyboardShortcuts.ts	Replaces the app-shortcut cascade with shared command dispatch while retaining modal and focused-input precedence.
src/ui/lib/appCommands.ts	Defines the named built-in command table and first-match dispatch behavior.
src/ui/lib/extensionCommands.ts	Converts registered extension commands into review-scoped bindings and rejects conflicts by load order.
src/ui/lib/sidebarPanes.ts	Centralizes sidebar identity, open-state reconciliation, placement, and width planning.
src/lib/commandKeys.ts	Implements validated chord parsing, exact extension-key matching, and synthetic events for conflict probing.
src/extensions/runExtension.ts	Adds validated command registration and includes commands in extension-factory rollback.
src/extension-api/types.ts	Publishes additive sidebar metadata, command registration, and command-context sidebar controls.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  K[Keyboard event] --> P{Modal or focused input owns key?}
  P -->|Yes| W[Widget handling]
  P -->|No| D[Shared command dispatcher]
  D --> B[Built-in commands]
  D --> E[Extension commands]
  E --> C[Extension command context]
  C --> S[Sidebar controls]
  S --> O[Open / close / toggle view]
  O --> R[Sidebar open-state reconciliation]
  R --> L[Multi-pane layout planner]
  L --> LP[Left panes]
  L --> V[Review stream]
  L --> RP[Right panes]

Loading

_{Reviews (1): Last reviewed commit: "feat(extensions): keyboard commands and ..." | Re-trigger Greptile}