fix(font): Add Sindhi-specific CSS for font clarity (@Shamsuddin45)#8202
Open
Shamsuddin45 wants to merge 2 commits into
Open
fix(font): Add Sindhi-specific CSS for font clarity (@Shamsuddin45)#8202Shamsuddin45 wants to merge 2 commits into
Shamsuddin45 wants to merge 2 commits into
Conversation
Add language-specific CSS for Sindhi language font clarity.
Member
|
hi, why is this needed. what makes sindhi different to other languages with joiningScript? |
Contributor
Author
Thanks for pointing that out. I noticed this specifically while testing the Sindhi language. With the default font and letter spacing, some Sindhi words were rendered incorrectly because certain joining characters appeared disconnected. Applying letter-spacing: normal together with a font that properly supports Sindhi (e.g. Noto Sans Arabic/Lateef) fixed the rendering. I haven't yet verified whether the same issue affects all other joiningScript languages, so I scoped the change to Sindhi to avoid changing typography for languages I hadn't tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add language-specific CSS for Sindhi language font clarity.
Description
Checks
packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languagespackages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themespackages/schemas/src/layouts.tsfrontend/static/layoutsfrontend/static/webfontspackages/schemas/src/fonts.tsfrontend/src/ts/constants/fonts.tsCloses #