Skip to content

fix: drop --accept-routes from tailscale args (v4 passes it by default) #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobias0106 merged 1 commit into from
Jul 28, 2026
Merged

fix: drop --accept-routes from tailscale args (v4 passes it by default) #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/pull-request-kotlin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,8 @@ jobs:
with:
authkey: ${{ env.TAILSCALE_AUTHKEY }}
hostname: "github-${{ github.run_id }}"
args: "--login-server https://headscale.monta.com --accept-routes"
# v4 passes --accept-routes itself; repeating it in args fails `tailscale up`
args: "--login-server https://headscale.monta.com"
# Wait for the tailnet path to SonarQube to actually be usable before
# scanning. `tailscale up` returns before DERP/route programming has
# settled, so the scanner's first call (GET /api/v2/analysis/version)
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/sonar-cloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@ jobs:
with:
authkey: ${{ env.TAILSCALE_AUTHKEY }}
hostname: "github-${{ github.run_id }}"
args: "--login-server https://headscale.monta.com --accept-routes"
# v4 passes --accept-routes itself; repeating it in args fails `tailscale up`
args: "--login-server https://headscale.monta.com"
- name: Run tests with coverage
env:
GHL_USERNAME: ${{ secrets.GHL_USERNAME }}
Expand Down
Loading