Repository navigation
[Certora] Only bad debt can desync credit from view - #1212
Conversation
aehyvari
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb0248f5ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The liquidation lock's `tload/tstore` kept `onlyBadDebtDesyncsCreditFromViewOnTake` from finishing, including when split into `buy` and `sell`. Summarizing `tExchange` and `tGet` as `NONDET` is sound here: the lock only gates take after the balance writes and liquidate before them, and no rule in this spec asserts the lock. The rule runs alone at depth 0; the parametric rule excludes take. Using configurations other than Depth 0 times out. The only solver capable of solving this is cvc5:nonlin (cvc4:nonlin for vacuity).
fb0248f to
c69d195
Compare
aehyvari
changed the title
aehyvari
changed the title
|
The two failing Certora checks look like memouts rather than counterexamples. |
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: Antti Hyvärinen <antti@morpho.xyz>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 610dc894d7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-authored-by: Quentin Garchery <garchery.quentin@gmail.com> Signed-off-by: Antti Hyvärinen <antti@morpho.xyz>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24e679cb28
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 717a7c5734
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
3 participants
Add onlyBadDebtDesyncsCreditFromView: if stored credit already matches the up-to-date view, they can diverge only when the market’s loss factor increases (bad debt socialization).
Related thread