Vendor nc's base64.c instead of fetching it - #30
Merged
Merged
Conversation
The runner could not reach the distro git host the file came from, so the build failed there twice while passing locally. base64.c now lives in build/nc/ and is copied in; the one-line prototype the patch supplied is a sed instead. Recipes gained a "files" key for this: sources that belong next to the Dockerfile rather than behind someone else's uptime. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mosajjal
force-pushed
the
fix/nc-vendor-base64
branch
from
September 2, 2026 10:08
6cdc796 to
be54966
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second CI-only failure on the same build: the runner could not reach
gitlab.alpinelinux.org, where
base64.candb64.patchwere being fetched from.base64.c(ISC, from BIND, unchanged) now lives inbuild/nc/and is copied into thebuild. The one-line prototype
b64.patchsupplied is asedinstead, so there is nopatch file to carry.
Recipes gained a
fileskey for this — sources that belong next to the Dockerfilerather than behind someone else's uptime.
Rebuilt clean locally: x64 and ARM both static, both smoke tests passing.
🤖 Generated with Claude Code